Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollspy and Gantry5 #1

Open
johanpeters opened this issue Jan 31, 2024 · 12 comments
Open

scrollspy and Gantry5 #1

johanpeters opened this issue Jan 31, 2024 · 12 comments
Assignees
@kevinsguides

Comments

@johanpeters
Copy link
Contributor

Hello,
i just found your plugin.. just what i was looking for.
i would like to use it on a gantry5 framework based website.

but it does not show.. i configured it, assigned to a module position, menu assignment but its not working.
it does not show the module at all.

should it work?
i have a blog page menu item.. and would like to have this module shown when you open one of the published articles.
the article has headings assigns.. plugin is enabled..
@kevinsguides
Copy link
Owner

Thanks for the comment. I clearly didn't test this enough! The module doesn't load for me either when I use it on many third-party templates. I only tested it on the default template... oops.
Please expect an update/fix shortly.

@kevinsguides kevinsguides self-assigned this Feb 1, 2024
@kevinsguides
Copy link
Owner

The issue is "hopefully" resolved with newest update, 1.2.1, please let me know if you still encounter issues.

@johanpeters
Copy link
Contributor Author

johanpeters commented Feb 1, 2024 via email

@kevinsguides kevinsguides reopened this Feb 1, 2024
@kevinsguides
Copy link
Owner

kevinsguides commented Feb 1, 2024 •
edited
Loading

I will release another update later today which hopefully resolves all module output issues, and fixes another minor problem with how I updated it yesterday.
For me, the floating panel does work with Gantry5 and their free helium template...
I am trying to make sticky module work better, but really this is something that's better handled by whatever template you're using.

Please wait for the update later today and see if that helps. If you'd like in the mean time...

  • Verify that the heading selectors (h2, h3, etc) in your article match the same levels set in the plugin settings
  • Verify that your article has more of those headings than whatever is set with the minimum # of headings option
  • I was unable to see your photo, please try submitting through github issues page directly: scrollspy and Gantry5 #1
  • or send me your email address with my contact form and I'll reply with an email address you can message me directly at
  • send screenshot of plugin settings

@johanpeters
Copy link
Contributor Author

johanpeters commented Feb 1, 2024 •
edited
Loading

Hello Kevin,

  1. article has several headings
  2. article has more headings then set in the plugin as minimum

see screenshot.. the index in the article is a plugin {index} that reads the heading and creates the index.
so you see, i have 17 article headings.

on the right contentspy also displays 17 numbers but without text.
when i use default settings no entries ar shown.. when i select number layout this is the result.

@kevinsguides
Copy link
Owner

If you're referring to the RegularLabs quick index plugin, I cannot make that compatible with this. You'll want to disable one or the other, since AutoSS also indexes all the headings in your article, in order to make it work. They both manipulate the headings and the article output. Quick index plugin also seems to break the floating panel option.
I've enhanced how the sticky module position feature works, but it does not seem to play nicely with the Gantry template I'm testing on. Sticky module positions are really something better left to the template developer, as I cannot create work arounds for every template out there.

Also, not sure that screenshot is what you meant to share? Looks like webmail history.

Latest update I just released has a few other improvements but I don't think they'll resolve your issue. If you're not using the quick index plugin, please let me know what other plugins you're using that affect headings and articles.

Hope that makes sense, and thanks for the feedback. If you happen to run into more problems with the other index plugin disabled, let me know.

@johanpeters
Copy link
Contributor Author

johanpeters commented Feb 2, 2024 via email •
edited
Loading

@johanpeters
Copy link
Contributor Author

Schermafbeelding 2024-02-02 om 08 23 45

@johanpeters
Copy link
Contributor Author

johanpeters commented Feb 2, 2024 via email

@kevinsguides
Copy link
Owner

I will review and get back to you

@kevinsguides kevinsguides reopened this Feb 2, 2024
@johanpeters
Copy link
Contributor Author

I will review and get back to you

greate Kevin..
currently the plugin place the header on top of the page..
its not readable on my site.. but for most sites with fixed headers) it will not work.
so, if possible it would be nice that the position of the header selected / active is not on top of the screen but for example 100px (to configure) padding on top..

so that the current header section is not completly on top, but a little bit below that.

if needed i can explain with a example image..

@kevinsguides
Copy link
Owner

Ah, I think I understand what you mean. Yes, that's an important feature I meant to add. I'll try to have something in the next day or two. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinsguides kevinsguides

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanpeters @kevinsguides