Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Debug text comes out of the serial port when listening for UDP connections #15

Closed
NameOfTheDragon opened this issue Nov 16, 2021 · 3 comments
Closed

Debug text comes out of the serial port when listening for UDP connections #15

NameOfTheDragon opened this issue Nov 16, 2021 · 3 comments
Labels
Improvement To improve the library

Comments

@NameOfTheDragon
Copy link

NameOfTheDragon commented Nov 16, 2021 •
edited
Loading

WiFiNINA_Generic/src/utility/server_drv.cpp

Line 56 in 2bb9903

#define KH_WIFININA_SERVER_DRV_DEBUG 1

There is what looks like a rogue #define in the source that enables serial debugging. I just added a call to UDP.parsePacket() and it spews debugging diagnostics constantly. Not ideal.

Would you like me to submit a PR? (assuming I can figure out how to build the code).
@khoih-prog
Copy link
Owner

Thanks. I'll remove it in master, which is a leftover from my previous debug. Sorry.

To remove and avoid unnecessary debugging messages, just change to

#define KH_WIFININA_SERVER_DRV_DEBUG   0

@khoih-prog
Copy link
Owner

Actually, there are more leftovers you have to fix

  1. spi_drv.cpp#L66

to be changed to

#define KH_WIFININA_SPI_DEBUG   0
  1. WiFiUdp_Generic.cpp#L59

to be changed to

#define KH_WIFININA_UDP_DEBUG   0

khoih-prog added a commit that referenced this issue Nov 16, 2021
@khoih-prog
Remove leftover DEBUG
51941fc 
Check [Debug text comes out of the serial port when listening for UDP connections #15](#15)
@khoih-prog
Copy link
Owner

The master has been updated with those leftovers removed.

Thanks for your contribution.

@khoih-prog khoih-prog added the Improvement To improve the library label Nov 16, 2021
khoih-prog added a commit that referenced this issue Nov 26, 2021
@khoih-prog
v1.8.14-1 to support ATmega4809
2530160 
### Releases v1.8.14-1

1. Fix examples to support ATmega4809 such as UNO_WIFI_REV2 and NANO_EVERY
2. Add support to generic `__SAMD21E1xA__`, `__SAMD21G1xA__` and `__SAMD21J1xA__`
3. Add `headers` in `library.json` for PIO
4. Update `platform.io`
5. Remove debug leftovers. Check [Debug text comes out of the serial port when listening for UDP connections #15](#15)
khoih-prog added a commit that referenced this issue Nov 26, 2021
@khoih-prog
Update Packages_Patches
e486338 
### Releases v1.8.14-1

1. Fix examples to support ATmega4809 such as UNO_WIFI_REV2 and NANO_EVERY
2. Add support to generic `__SAMD21E1xA__`, `__SAMD21G1xA__` and `__SAMD21J1xA__`
3. Add `headers` in `library.json` for PIO
4. Update `platform.io`
5. Remove debug leftovers. Check [Debug text comes out of the serial port when listening for UDP connections #15](#15)
khoih-prog added a commit that referenced this issue Nov 26, 2021
@khoih-prog
v1.8.14-1 to support ATmega4809
8a258d6 
### Releases v1.8.14-1

1. Fix examples to support ATmega4809 such as UNO_WIFI_REV2 and NANO_EVERY
2. Add support to generic `__SAMD21E1xA__`, `__SAMD21G1xA__` and `__SAMD21J1xA__`
3. Add `headers` in `library.json` for PIO
4. Update `platform.io`
5. Remove debug leftovers. Check [Debug text comes out of the serial port when listening for UDP connections #15](#15)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Improvement To improve the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NameOfTheDragon @khoih-prog