KeyboardProvider breaks translucent system navigation bar

[whalemare]

Describe the bug
When I wrap my app with

return <KeyboardProvider statusBarTranslucent>{children}</KeyboardProvider>

Android system navigation bar becomes colored, not translucent

Code snippet

return <KeyboardProvider statusBarTranslucent>{children}</KeyboardProvider>

styles.xml

    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <item name="android:forceDarkAllowed" tools:ignore="NewApi">false</item>

        <item name="android:windowTranslucentStatus">true</item>
        <item name="android:windowTranslucentNavigation">true</item>
        <item name="android:statusBarColor">@android:color/transparent</item>
        <item name="android:navigationBarColor">@android:color/transparent</item>
    </style>

Repo for reproducing
I can do it later if you need it

To Reproduce

1. Wrap app with KeyboardProvider
2. Use translucent navigation
3. Run app

Expected behavior

Actual behavior

Smartphone (please complete the following information):

• Desktop OS: MacOS
• Device: Android Nexus 5
• OS: API 33
• RN version: 0.71.2
• RN architecture: old, paper
• JS engine: Hermes
• Library version: 1.4.3

Additional context
no applicable

[kirillzyusko]

Hi @whalemare

Nice point! Actually I think it kind of expected behavior, since in the code I specify it like

react-native-keyboard-controller/android/src/main/java/com/reactnativekeyboardcontroller/managers/KeyboardControllerViewManagerImpl.kt

Line 47 in 9986f5f

insets?.getInsets(WindowInsetsCompat.Type.navigationBars())?.bottom ?: 0,

Which literally means "apply default padding". I think I need to introduce navigationBarTranslucent prop to make it configurable. For now you can use patch-package and instead of this line simply specify 0 (just remove insets?.getInsets(WindowInsetsCompat.Type.navigationBars())?.bottom ?: and leave 0).

Please, let me know, if the "fix" with substituting 0 instead of ternary operator actually helps or not. If it helps then I will create a PR soon 👀

[whalemare]

Yes, it helps! Thanks a lot

[kirillzyusko]

@whalemare awesome! I will submit a PR in next few days 👀

[kirillzyusko]

I've merged a PR that adds new property called navigationBarTranslucent on KeyboardProvider

So you'll need to use:

<KeyboardProvider navigationBarTranslucent>
...
</KeyboardProvider>

In order not to break translucency specified by android styles.

[kirillzyusko]

Fixed in 1.4.4 😊