-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simple component for keyboard avoiding #154
Comments
@beqramo maybe it makes sense to replicate default components, such as |
@kirillzyusko I updated the codes. there were some stupid mistakes :). |
Oh you mean to add as an improvement, moving the input field with the keyboard if it is going to be behind? |
@beqramo With the support of this library you can achieve better animations of I thought about adding basic components into the package, but I need to allocate time for that 😅 |
Yes, this lib is amazing. I am indicating some missing components that instead of in the example file can be inside the package itself. |
I agree with @beqramo, would be awesome to have some components replacing the |
@Noitham for sure I'll add them, but a little bit later. Right now want to close some old GH issues, enhance API a little bit and after that I'll develop these By the way - contributions are always welcome! If you have a desire to add them to the library - you can open PR and after a review I'll merge it 🙂 |
## 📜 Description Added `KeyboardAvoidingView` based on `useKeyboardHandler` hook. ## 💡 Motivation and Context It was requested functionality and I agree that similar components should be provided out-of-box. As a first component I decided to re-implement `KeyboardAvoidingView`, because the implementation is very easy 👀 Later I'm planning to add more components, so stay tuned 😎 Closes #154 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - added `KeyboardAvoidingView`; - added corresponding example app. ### Docs - added section about `KeyboardAvoidingView`; - added lottie that shows visual difference between implementations. ## 🤔 How Has This Been Tested? Tested on: - Xiaomi Redmi Note 5 Pro; - Pixel 7 Pro; - iPhone 14 Pro (iOS 16.5, iOS 17) <- simulator; - iPhone 6s (iOS 15.6). ## 📸 Screenshots (if appropriate): https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/0fc849d4-4c15-41ab-875f-f49c555256f3 ## 📝 Checklist - [x] CI successfully passed
@beqramo you can use |
Is your feature request related to a problem? Please describe.
Hi,
In most of the cases in app we just want to move button on top if it is open or something like that.
So it is missing base component that will do this thing. it isn't handy to build animation again and again for simply placing button on top.
Because of that, I would suggest adding base Component that will do simple avoiding like the below:
This solution will work only if it is a fixed button, without any scroll.
Depending on where you will put the relative position in the parent component it most likely will work in most cases.
Sorry I didn't answer other paragraphs and I removed it.
Thank you.
Great library btw.
The text was updated successfully, but these errors were encountered: