Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useKeyboardAnimation doesn't work on Samsung Galaxy Note 20 #55

Closed
fobos531 opened this issue Aug 17, 2022 · 8 comments
Closed

useKeyboardAnimation doesn't work on Samsung Galaxy Note 20 #55

fobos531 opened this issue Aug 17, 2022 · 8 comments
Assignees
Labels
🤖 android Android specific 🐛 bug Something isn't working

Comments

@fobos531
Copy link

fobos531 commented Aug 17, 2022

Describe the bug
I suppose the keyboard height values aren't exposed to the hook correctly on Samsung Galaxy Note 20. Something's probably wrong with keyboard height events there

Repo for reproducing
Simply use the example app from this repo - the key is running the app on a Samsung Galaxy Note 20.

Expected behavior
Keyboard height values should be correctly exposed to the useKeyboardAnimation hook on Samsung Galaxy Note 20

Screenshots
CleanShot 2022-08-18 at 00 09 53 Under the keyboard - there are two inputs. The keyboard height values are being correctly returned for other Samsung Galaxy devices, like the Galaxy S21. It's the Galaxy Note 20 that is problematic.

Smartphone (please complete the following information):

  • Desktop OS: MacOS Ventura
  • Device: Samsung Galaxy Note 20
  • OS: Android 10 & Android 12
  • JS engine Hermes
  • Library version Latest

Additional context:
It seems its something specific to Galaxy Note 20 (since it works on other Samsung devices), but I'm not sure what that would be.

@fobos531 fobos531 added the 🐛 bug Something isn't working label Aug 17, 2022
@kirillzyusko
Copy link
Owner

Hi @fobos531

It's really interesting why it doesn't work on Galaxy Note 20 🤔
Anyway, I will try to reproduce the problem using Samsung Remote Test Lab - I don't have a physical device, so I have to rely only on it.
Hopefully it will be reproducible there and I can figure out what's the problem.

If you could reproduce it on any simulators (Android Studio/Genymotion) - let me know :)

@fobos531
Copy link
Author

fobos531 commented Aug 18, 2022

Hey, thank you very much for looking into it! Yeah, unfortunately I also don't have this device either so I had to rely on Browserstack's service to reproduce this bug - but if there's anything else I can do, let me know, I'm happy to help!

@kirillzyusko
Copy link
Owner

@fobos531 never heard about Browserstack🤔 Is it publicly available (i. e. I can sign up and get a remote device for testing?). And if yes - is it free?

@fobos531
Copy link
Author

@fobos531 never heard about Browserstack🤔 Is it publicly available (i. e. I can sign up and get a remote device for testing?). And if yes - is it free?

Their remote device testing service is called App Live. Unfortunately it doesn't looks there is a fully free plan: https://www.browserstack.com/accounts/subscriptions?product=app-live

@kirillzyusko
Copy link
Owner

Hi @fobos531
Just letting you know, that I've tested example app on Note 20 (Android 11) and it works good:

Screen.Recording.2022-08-18.at.18.23.00.mov

I know, that you've tested it on Android 10 & 12, so it may be the issue. Anyway I will try to catch a time point where more devices will be available (and hopefully I can reproduce the problem) 🤞

@kirillzyusko
Copy link
Owner

Note 20 (with Android 10/12) is still not available so I decided to test it on Note 20 Ultra (Android 12) - still works good:

Note20Ultra-Android12.mov

@kirillzyusko kirillzyusko added the 🤖 android Android specific label Aug 21, 2022
@kirillzyusko
Copy link
Owner

@fobos531 just tested it on Note20 Android 12 - still, everything works fine 🤷‍♂️

S20-API32.mov

I ran app from main branch (it uses RN 0.69). Would you mind to run example app from main branch on your device?
Because I can not reproduce the issue and I don't understand where the problem is 😔

@fobos531
Copy link
Author

Hmm, if it works fine for you, maybe it's something related to my setup - I'll hopefully check it out when I have some time to do so, I'm currently swamped with work. Until then, I'll close this issue. Once again, thank you for the effort put into this issue! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants