Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove undesired prop memoization #820

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Feb 19, 2025

📜 Description

Get rid off undesired config memoization.

💡 Motivation and Context

When navigationBarTranslucent prop is set we may already mount a view and keep default navigationBarTranslucent value in KeyboardAnimationCallback.

The new approach assures that we have a shared config + we update hasTranslucentNavigationBar property when props are updated.

Closes #818

📢 Changelog

Android

  • don't use getter for config;
  • update hasTranslucentNavigationBar when prop gets changed;

🤔 How Has This Been Tested?

Tested in reproduction repository.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

Copy link
Contributor

github-actions bot commented Feb 19, 2025

📊 Package size report

Current size Target Size Difference
167566 bytes 167573 bytes -7 bytes 📉

@kirillzyusko kirillzyusko changed the title fix: evaluate prop on demand fix: remove undesired prop memoization Feb 19, 2025
@kirillzyusko kirillzyusko marked this pull request as ready for review February 19, 2025 16:33
@kirillzyusko kirillzyusko merged commit 1a6f72a into main Feb 19, 2025
16 checks passed
@kirillzyusko kirillzyusko deleted the fix/evaluate-props-on-demand branch February 19, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect positioning of KeyboardStickyView when the keyboard is open on Android (old RN architecture)
1 participant