fix: remove undesired prop memoization #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Get rid off undesired config memoization.
💡 Motivation and Context
When
navigationBarTranslucent
prop is set we may already mount a view and keep defaultnavigationBarTranslucent
value inKeyboardAnimationCallback
.The new approach assures that we have a shared config + we update
hasTranslucentNavigationBar
property when props are updated.Closes #818
📢 Changelog
Android
config
;hasTranslucentNavigationBar
when prop gets changed;🤔 How Has This Been Tested?
Tested in reproduction repository.
📸 Screenshots (if appropriate):
📝 Checklist