-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyboardVerticalOffset documentation issue #887
Comments
Hey @slavko-lukic
This is a distance between top of the screen and your Assume if you have layout like
In this case you would need to specify Really curious to hear your thoughts 👀 |
Hey @kirillzyusko I'd maybe just paraphrase prop annotation so that it's clear that offset should be distance from top of the screen to the That example you gave or visual example could be added to your website for additional clarity. |
@slavko-lukic I'm trying to draw an example using GPT-solutions, but they fail to do that 🙈 I think I'll draw a diagram and add it to website soon + change description 🙂 |
@kirillzyusko That's great 🙌 By the way, keep up the good work. This library is solving one of the most annoying problems in react native. 👍 |
…anation (#890) ## 📜 Description Added a better explanation of what `keyboardVerticalOffset` does and when to use it. ## 💡 Motivation and Context Clearer documentation -> less bug reports 😎 Closes #887 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### Docs - added better explanation of `keyboardVerticalOffset property`; ## 🤔 How Has This Been Tested? Tested via preview. ## 📸 Screenshots (if appropriate): <img width="1003" alt="image" src="https://github.com/user-attachments/assets/19a63ae9-305d-4828-be4a-a8af69444e11" /> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Published new version of documentation - should be clearer now 😊 |
Hello.
Both this library and
KeyboardAvoidingView
fromreact-native
have very vague description forkeyboardVerticalOffset
prop.Distance between the top of the user screen and the React Native view. This may be non-zero in some cases. Defaults to 0.
What is this "React Native view" in question? Is it the main app view? Is it the KeyboardAvoidingView being used?
I suggest rewriting this to be more clear so that people stop tuning this randomly though trial and error until they get it right.
The text was updated successfully, but these errors were encountered: