Crashes on iOS 15 #93
Assignees
Comments
|
@OmgDef it happens exactly on iOS 15.0? Nor 15.6 - exactly 15.0? I'm asking because i've tested app on iOS 15.6 and everything worked correctly 🤷♂️ |
|
@kirillzyusko I could not repeat the issue on a fresh project. It seems there is a conflict with one of my dependencies. |
|
@OmgDef okay, let me know if you find a conflict and don't hesitate to re-open this issue or create a new one 🙂 |
1 task
kirillzyusko
added a commit
that referenced
this issue
Nov 4, 2022
## 📜 Description Added optional chaining instead of forced unwrapping. Fixes crash described in #93 ## 💡 Motivation and Context In fact it's not a fix and is more avoiding NPE rather than a full fix. But anyway, missing animation is better, than a crash of application 🤷♂️ ## 📢 Changelog ### iOS - avoid usage of forced unwrapping ## 🤔 How Has This Been Tested? Tested locally on: - iPhone 13 Pro (iOS 15.0); ## 📝 Checklist - [x] CI successfully passed
|
We had one user hit this on an iphone 15 Max, iOS 17.2.1. We are using version |
|
@bcgilliom can you check if #359 fixes the problem? |
2 tasks
kirillzyusko
added a commit
that referenced
this issue
Feb 19, 2024
## 📜 Description Do not use force casting in swift - replaced with optional casting and guard statements. ## 💡 Motivation and Context In sentry one of library user seen this: ```bash Thread 0 - (TH_STATE_WAITING) 0 Trusted +0x5746c0 Swift runtime failure: Unexpectedly found nil while unwrapping an Optional value (KeyboardMovementObserver.swift:109:65) 1 Trusted +0x5705cc KeyboardMovementObserver.observeValue(forKeyPath:of:change:context:) (<compiler-generated>) 2 Foundation +0x99e54 _NSKeyValueNotifyObserver 3 Foundation +0x99cf0 _NSKeyValueDidChange 4 Foundation +0x99b20 -[NSObject(NSKeyValueObservingPrivate) _changeValueForKeys:count:maybeOldValuesDict:maybeNewValuesDict:usingBlock:] 5 Foundation +0x99850 -[NSObject(NSKeyValueObservingPrivate) _changeValueForKey:key:key:usingBlock:] 6 Foundation +0x12cb94 __NSSetPointValueAndNotify 7 UIKitCore +0x615f4 -[UIView(Geometry) _applyISEngineLayoutValuesToBoundsOnly:] 8 UIKitCore +0x60e44 -[UIView(Geometry) _resizeWithOldSuperviewSize:] 9 CoreFoundation +0x353f0 ___NSARRAY_IS_CALLING_OUT_TO_A_BLOCK__ ``` It was very random crash, but still - it's not a good practice to use force casting and as a prof -> it produces a crash in certain cases. So in this PR I replaced it with more safe operators. Closes #93 (comment) ## 📢 Changelog ### iOS - do not force cast KVO values ## 🤔 How Has This Been Tested? There is no way to test whether crashes are gone or not, but I think they should gone (in worst case we will have a new stacktrace). ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The app crashes right before keyboard is shown on iOS 15. On iOS 16 it works just fine.
Swift runtime failure: Unexpectedly found nil while unwrapping an Optional value
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: