Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Plumbum support #116

Open
3 tasks
henryiii opened this issue Aug 27, 2015 · 1 comment
Open
3 tasks

Feature Request: Plumbum support #116

henryiii opened this issue Aug 27, 2015 · 1 comment

Comments

@henryiii
Copy link
Contributor

I'm looking at adding argcomplete support to Plumbum.cli (Someone might also look at Click at some point in the future, hopefully). It's really pretty simple to add directly to Plumbum, since there is no need for monkey patching. I just need a few things:

  • Can I have permission to use the same flag and file descriptors to connect as argcomlete? I don't want to have a new, separate global completer for each library.
  • Can I include a copy the global argcomplete script? I'm not sure about the licences, I think you can give permission to include it under plumbum's licence? This is optional, as simply listing "argcomplete support" for plumbum and "plumbum support" for argcomplete would probably work fine.
  • Do you have any recommendations, or would you like to help create this? The process of creating suggestions is the part that will need work.

I have an early proof of concept mentioned here: tomerfiliba/plumbum#212, you can take a look, it supports - and -- options.

@kislyuk
Copy link
Owner

kislyuk commented Sep 15, 2015

You raise an interesting question of what to do when two or more programs want to use complete -D. I'm not aware of a good answer for that. Do they stack properly?

It would be nice to define a standard Python shell completions interface, including things like file descriptors, muting, exit semantics, environment variables, etc. I'm open to that possibility, but someone will need to write it up (I can review it) and present it to the community for comments.

Both packages are provided under permissive licenses (Apache and BSD) so you can do whatever you want. I don't have any strong opinions aside from the obvious point that you should think about how these packages will interact and might conflict when simultaneously used in bash and in Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants