Skip to content

Commit c5e15fc

Browse files
committed
Add doc8 for static analysis
and restructure GitHub CI job definition to reduce repetition
1 parent c80153c commit c5e15fc

File tree

3 files changed

+11
-32
lines changed

3 files changed

+11
-32
lines changed

.github/workflows/testing.yml

Lines changed: 6 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ on:
99
- "*"
1010

1111
jobs:
12-
flake8:
13-
name: flake8 / Py${{ matrix.python-version }}
12+
static_analysis:
13+
name: ${{ matrix.make-command }} / Py${{ matrix.python-version }}
1414
runs-on: ubuntu-latest
1515
strategy:
16-
fail-fast: true
16+
fail-fast: false
1717
matrix:
1818
python-version: [3.6]
19+
make-command: [doc8, flake8, pylint]
1920

2021
steps:
2122

@@ -32,33 +33,6 @@ jobs:
3233
sudo apt-get install virtualenv libkrb5-dev
3334
pip install -r devel.txt
3435
35-
- name: Verify flake8
36+
- name: Verify ${{ matrix.make-command }}
3637
run: |
37-
make flake8
38-
39-
pylint:
40-
name: pylint / Py${{ matrix.python-version }}
41-
runs-on: ubuntu-latest
42-
strategy:
43-
fail-fast: true
44-
matrix:
45-
python-version: [3.6]
46-
47-
steps:
48-
49-
- name: Check out code
50-
uses: actions/checkout@v2
51-
52-
- name: Set up Python ${{ matrix.python-version }}
53-
uses: actions/setup-python@v1
54-
with:
55-
python-version: ${{ matrix.python-version }}
56-
57-
- name: Install Python dependencies
58-
run: |
59-
sudo apt-get install virtualenv libkrb5-dev
60-
pip install -r devel.txt
61-
62-
- name: Verify pylint
63-
run: |
64-
make pylint
38+
make ${{ matrix.make-command }}

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ pylint:
99
test:
1010
coverage run --source tcms_api setup.py test
1111

12+
.PHONY: doc8
13+
doc8:
14+
doc8 README.rst
15+
1216
.PHONY: build
1317
build:
1418
./tests/check-build

devel.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
-r requirements.txt
22

3+
doc8
34
flake8
45
pylint
56
twine

0 commit comments

Comments
 (0)