JN: fix wait condition for customs sounds

Author: knah

JoinNotifier/JoinNotifier.csproj

@@ -4,7 +4,7 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <VrcReferences>true</VrcReferences>
     <UseAltLibs>true</UseAltLibs>
-    <AssemblyVersion>1.0.1</AssemblyVersion>
+    <AssemblyVersion>1.0.2</AssemblyVersion>
   </PropertyGroup>
   <ItemGroup>
     <EmbeddedResource Include="joinnotifier.assetbundle" />

JoinNotifier/JoinNotifierMod.cs

@@ -16,7 +16,7 @@
 using VRC.Management;
 using Object = UnityEngine.Object;
 
-[assembly:MelonInfo(typeof(JoinNotifierMod), "JoinNotifier", "1.0.1", "knah", "https://github.com/knah/VRCMods")]
+[assembly:MelonInfo(typeof(JoinNotifierMod), "JoinNotifier", "1.0.2", "knah", "https://github.com/knah/VRCMods")]
 [assembly:MelonGame("VRChat", "VRChat")]
 
 namespace JoinNotifier
@@ -91,7 +91,7 @@ public IEnumerator InitThings()
                 var uwr = UnityWebRequest.Get($"file://{Path.Combine(Environment.CurrentDirectory, CustomJoinSoundFileName)}");
                 uwr.SendWebRequest();
 
-                while (uwr.isDone) yield return null;
+                while (!uwr.isDone) yield return null;
 
                 myJoinClip = WebRequestWWW.InternalCreateAudioClipUsingDH(uwr.downloadHandler, uwr.url, false, false, AudioType.UNKNOWN);
             }
@@ -108,7 +108,7 @@ public IEnumerator InitThings()
                 var uwr = UnityWebRequest.Get($"file://{Path.Combine(Environment.CurrentDirectory, CustomLeaveSoundFileName)}");
                 uwr.SendWebRequest();
 
-                while (uwr.isDone) yield return null;
+                while (!uwr.isDone) yield return null;
 
                 myLeaveClip = WebRequestWWW.InternalCreateAudioClipUsingDH(uwr.downloadHandler, uwr.url, false, false, AudioType.UNKNOWN);
             }

ReleaseChangelog.md

@@ -1,6 +1,4 @@
 Changes:
- * JoinNotifier: fixed for build 1102
- * Mirror Resolution Unlimiter: fixed settings not being applied on startup
- * UI Expansion Kit: fixed quick menu expando panels being shown all the time regardless of settings or hiding them manually
+ * JoinNotifier: fixed custom sounds breaking the mod occasionally
 
 **USE IT AT YOUR OWN RISK.** Modding the client is against VRChat ToS. I am not responsible for any bans or other punishments you may get by using these mods!