Skip to content

Commit 08e8c32

Browse files
authored
Cleanup net-certmanager integration (#15168)
* Cleanup net-certmanager integration * Remove additional /
1 parent 2dd44d9 commit 08e8c32

File tree

7 files changed

+4
-20
lines changed

7 files changed

+4
-20
lines changed

config/core/configmaps/logging.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ metadata:
2222
app.kubernetes.io/component: logging
2323
app.kubernetes.io/name: knative-serving
2424
annotations:
25-
knative.dev/example-checksum: "53fda05f"
25+
knative.dev/example-checksum: "9f25d429"
2626
data:
2727
_example: |
2828
################################
@@ -73,7 +73,6 @@ data:
7373
loglevel.webhook: "info"
7474
loglevel.activator: "info"
7575
loglevel.hpaautoscaler: "info"
76-
loglevel.net-certmanager-controller: "info"
7776
loglevel.net-istio-controller: "info"
7877
loglevel.net-contour-controller: "info"
7978
loglevel.net-kourier-controller: "info"

test/config/ytt/core/overlay-config-logging.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,4 @@ data:
3333
loglevel.activator: "debug"
3434
loglevel.hpaautoscaler: "debug"
3535
loglevel.net-istio-controller: "debug"
36-
loglevel.net-certmanager-controller: "debug"
3736
loglevel.net-contour-controller: "debug"

test/config/ytt/ingress/istio/istio-certmanager-webhook.yaml

-14
This file was deleted.

test/e2e-common.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ function install() {
309309
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/ingress/${ingress}")
310310
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/certmanager/kapp-order.yaml")
311311
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/certmanager/kapp-secret-upgrade.yaml")
312+
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/certmanager/net-certmanager-config.yaml")
312313
YTT_FILES+=("${REPO_ROOT_DIR}/third_party/cert-manager-${CERT_MANAGER_VERSION}/cert-manager.yaml")
313-
YTT_FILES+=("${REPO_ROOT_DIR}/third_party/cert-manager-${CERT_MANAGER_VERSION}/net-certmanager.yaml")
314314

315315
if (( MESH )); then
316316
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/mesh")

test/e2e/certmanager/e2e-common.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function test_setup() {
4242
kubectl apply -f third_party/cert-manager-latest/cert-manager.yaml || return 1
4343
wait_until_pods_running cert-manager || return 1
4444

45-
echo ">> Bringing up net-certmanager Controller"
45+
echo ">> Bringing up serving controller with net-certmanager enabled"
4646
ko apply -f config || return 1
4747
echo ">> Waiting for Serving components to be running..."
4848
wait_until_pods_running knative-serving || return 1

test/e2e/externaldomaintls/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ feature documentation.
55

66
# Prerequisites
77
* Have `cert-manager` installed
8-
* Have `net-certmanager` installed
8+
* Have the Knative certmanager integration enabled
99
* Upload test images with `./test/upload-test-images.sh`
1010
* Enable `external-domain-tls` with `kubectl patch cm config-network -n knative-serving -p '{"data":{"external-domain-tls": "enabled"}}'`
1111

0 commit comments

Comments
 (0)