Repository navigation
Don't scrape pods via HTTP if the activator in path. #7324
Description
When the activator is in the routing path, scraping the pods is kinda useless as their information is effectively zeroed out, because all requests are considered "proxied", thus the activator metrics take precedence. We can use that to make our system more efficient in these cases!
I propose two steps to go about this:
- Never scrape if TBC=-1. The activator will always be in path in this case, so we never need to scrape really.
- Start/Stop scraping if activator is in path or not. This is a little more tricky as we need to make sure that we start scraping timely once we notice the activator will be taken off the path.
As the PodAutoscaler owns all of these decisions, this should be doable for us. As it's a good-first-issue, I'd love to see it land in two separate pieces as laid out though.
Note: I'm happy to mentor first-time contributors here. The changes needed should be fairly small in terms of number of files to touch.
Activity
knative-prow-robot commentedon Mar 19, 2020
@markusthoemmes:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the
/remove-good-first-issuecommand.Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
dsimansk commentedon Mar 19, 2020
I'd like to give it a try to look into Serving internals a bit more.
/assign dsimansk
vagababov commentedon Mar 19, 2020
/cc @taragu
BTW, this is also one of the ways you can improve GSD, if we extend the activator reporting capabilities (not necessarily a good idea, but something to consider).
12 remaining items
nader-ziada commentedon Apr 29, 2022
/assign
dprotaso commentedon Jun 29, 2022
Related PR: #13027
If there are no ready activators but ready pod endpoints requests will bypass the activator even if TBC=-1
dprotaso commentedon Jan 11, 2024
/unassign @nader-ziada
yenniechen commentedon May 28, 2024
@dprotaso @markusthoemmes
yenniechen commentedon May 28, 2024
/assign
Alexander-Kita commentedon Nov 13, 2025
Does this issue still need work? I would be glad to attempt a solution @markusthoemmes
evankanderson commentedon Nov 15, 2025
@dprotaso or @skonto would probably be better able to speak to the current situation.
Alexander-Kita commentedon Nov 20, 2025
/assign