Skip to content

Decode all CAs in secret for activator #13877

Open
#16707
Open
Decode all CAs in secret for activator#13877
#16707
Labels
kind/featureWell-understood/specified features, ready for coding.triage/acceptedIssues which should be fixed (post-triage)

Description

@nak3
nak3
opened on Apr 13, 2023

As per #13854 (comment)

Currently we decod only one CA in the top of the secret.

serving/pkg/activator/certificate/cache.go

Line 96 in 018c7f8

block, _ := pem.Decode(secret.Data[certificates.CaCertName])

It should be fine at this moment, but it should decode all CAs in the secret especially if we support BYO CA cert.

Activity

  1. nak3
    added
    kind/featureWell-understood/specified features, ready for coding.
    on Apr 13, 2023
  2. ReToCode
    added
    triage/acceptedIssues which should be fixed (post-triage)
    on Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureWell-understood/specified features, ready for coding.triage/acceptedIssues which should be fixed (post-triage)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions