fix(news): avoid false digest failure after build

Author: koala73

server/worldmonitor/news/v1/list-feed-digest.ts

@@ -161,6 +161,19 @@ async function settleBeforeDeadline<T>(
   }
 }
 
+function finishSuccessfulDigestAttempt(
+  variant: string,
+  lang: string,
+  slot: ReturnType<typeof beginDigestAttempt>,
+): null {
+  completeDigestAttempt(variant, lang, slot);
+  // Publication remains inside the shared in-flight promise. Clear the build
+  // identity before that phase starts so an outer response timeout cannot
+  // relabel a completed build as `build-error` and overwrite its canonical
+  // publication with a negative sentinel.
+  return null;
+}
+
 type DigestFeedEntry = { attemptId: string; category: string; feed: ServerFeed };
 
 /**
@@ -2042,7 +2055,7 @@ export async function listFeedDigest(
             const result = await buildDigest(variant, lang, (await revokedPromise).urls);
             const totalItems = Object.values(result.categories).reduce((sum, b) => sum + b.items.length, 0);
             if (totalItems > 0) {
-              completeDigestAttempt(variant, lang, leaderSlot);
+              leaderSlot = finishSuccessfulDigestAttempt(variant, lang, leaderSlot);
               return result;
             }
             leaderFailure = publishFailedAttempt(
@@ -2056,15 +2069,17 @@ export async function listFeedDigest(
             completeDigestAttempt(variant, lang, leaderSlot);
             return null;
           } catch (err) {
-            leaderFailure = publishFailedAttempt(
-              variant,
-              lang,
-              digestCacheKey,
-              leaderSlot,
-              'build-error',
-              30,
-            );
-            completeDigestAttempt(variant, lang, leaderSlot);
+            if (leaderSlot) {
+              leaderFailure = publishFailedAttempt(
+                variant,
+                lang,
+                digestCacheKey,
+                leaderSlot,
+                'build-error',
+                30,
+              );
+              completeDigestAttempt(variant, lang, leaderSlot);
+            }
             throw err;
           }
         },
@@ -3170,6 +3185,7 @@ export const __testing__ = {
   fallbackDigestCache,
   markFallbackCoverageStale,
   settleBeforeDeadline,
+  finishSuccessfulDigestAttempt,
   lastGoodStoreTesting,
   beginDigestAttempt,
   completeDigestAttempt,

tests/digest-lastgood.test.mts

@@ -1017,6 +1017,25 @@ describe('durable last-good wiring (#7084)', () => {
     assert.ok(Date.now() - started < 2_000, 'the absolute deadline must bound every unresolved tail');
   });
 
+  it('a completed build is not relabeled as failed when publication crosses the response deadline', async () => {
+    reset();
+    let slot = mod.__testing__.beginDigestAttempt('full', 'en', new Date(NOW).toISOString());
+    slot = mod.__testing__.finishSuccessfulDigestAttempt('full', 'en', slot);
+
+    const publication = await mod.__testing__.settleBeforeDeadline(
+      new Promise(() => {}),
+      Date.now() + 20,
+      'unavailable',
+    );
+    assert.equal(publication, 'unavailable');
+    assert.equal(slot, null, 'successful build completion must clear the pending leader identity');
+    assert.equal(
+      stub.transactionCalls.length,
+      0,
+      'a publication timeout must not write a build-error attempt or canonical sentinel',
+    );
+  });
+
   it('fresh and cached serving fail CLOSED when revocations are unreadable', async () => {
     reset();
     stub.pipeline = async () => [{ error: 'ERR' }];