Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor listingCart #11123

Open
hassnian opened this issue Oct 21, 2024 · 0 comments
Open

Refactor listingCart #11123

hassnian opened this issue Oct 21, 2024 · 0 comments
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt

Comments

@hassnian
Copy link
Contributor

hassnian commented Oct 21, 2024 •
edited
Loading

after #11096

listingCart is now used to transfer items and list items , refactor it accordingly

mass nft transfer should work

reused a lot of the listing cart code , will create a separate pr after this is merged, since now listingCart has multiple uses will refactor it accordingly , I think that It's going to be more manageable reviewing and testing wise

_Originally posted by @hassnian in #11096
@hassnian hassnian added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Oct 21, 2024
@hassnian hassnian mentioned this issue Dec 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hassnian