Fixed some IDE warnings and reformat codes

Author: siamak2

tests/Casts/StateCaster.php

@@ -2,44 +2,45 @@
 
 namespace Kodeine\Metable\Tests\Casts;
 
+use Exception;
 use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
 
 class StateCaster implements CastsAttributes
 {
-    private string $baseStateClass;
-
-    public function __construct(string $baseStateClass)
-    {
-        $this->baseStateClass = $baseStateClass;
-    }
-
+	private $baseStateClass;
+	
+	public function __construct(string $baseStateClass) {
+		$this->baseStateClass = $baseStateClass;
+	}
+	
 	public function get($model, $key, $value, $attributes) {
 		if ( is_null( $value ) ) return null;
-
-		if (! is_subclass_of($value, $this->baseStateClass)) {
+		
+		if ( ! is_subclass_of( $value, $this->baseStateClass ) ) {
 			return null;
 		}
-
+		
 		$stateClassName = $value::config()['default'];
-
-		$state = new $stateClassName($model);
-
-		return $state;
+		
+		return new $stateClassName( $model );
 	}
 
+	/**
+	 * @throws Exception
+	 */
 	public function set($model, $key, $value, $attributes) {
 		if ( is_null( $value ) ) return null;
-
-		if (! is_subclass_of($value, $this->baseStateClass)) {
-			throw new \Exception('Invalid state class.');
+		
+		if ( ! is_subclass_of( $value, $this->baseStateClass ) ) {
+			throw new Exception( 'Invalid state class.' );
 		}
-
-		$value = new $value($model);
-
-		if ($value instanceof $this->baseStateClass) {
-			$value->setField($key);
+		
+		$value = new $value( $model );
+		
+		if ( $value instanceof $this->baseStateClass ) {
+			$value->setField( $key );
 		}
-
+		
 		return $value->getMorphClass();
 	}
 }

tests/Casts/UserCastedObject.php

@@ -6,40 +6,41 @@
 
 abstract class UserCastedObject implements Castable
 {
+	public static $name;
+	public $model;
+	public $stateConfig;
+	public $field;
+	
 	public function __construct($model) {
 		$this->model = $model;
 		$this->stateConfig = static::config();
 	}
-
-	public static function config()
-	{
+	
+	public static function config() {
 		return [
 			'default' => null,
 		];
 	}
 
 	public static function castUsing(array $arguments) {
-		return new StateCaster(static::class);
+		return new StateCaster( static::class );
 	}
-
-    public function setField(string $field): self
-    {
-        $this->field = $field;
-
-        return $this;
-    }
-
-    public static function getMorphClass(): string
-    {
-        return static::$name ?? static::class;
-    }
-
-	public function make(string $name, $model)
-	{
-		if (is_null($name)) {
+	
+	public function setField(string $field): self {
+		$this->field = $field;
+		
+		return $this;
+	}
+	
+	public static function getMorphClass(): string {
+		return static::$name ?? static::class;
+	}
+	
+	public function make(?string $name, $model) {
+		if ( is_null( $name ) ) {
 			return null;
 		}
-
-		return new $name($model);
+		
+		return new $name( $model );
 	}
 }

tests/Casts/UserState/DefaultState.php

@@ -4,12 +4,13 @@
 
 class DefaultState extends State
 {
-	public string $description;
+	public $description;
 
+	/** @noinspection PhpMissingParentConstructorInspection */
 	public function __construct() {
 		$this->description = $this->description();
 	}
-
+	
 	public function description(): string {
 		return 'This is a default description.';
 	}

tests/MetableTest.php

@@ -52,14 +52,14 @@ public static function setUpBeforeClass(): void {
 
 	public function testCast() {
 		$user = new UserTest;
-
+		
 		$this->assertNull( $user->state, 'Casted object should be null by default' );
-
+		
 		$user->state = DefaultState::class;
-
-		$this->assertTrue( $user->state instanceof DefaultState, 'Casted object should be instanceof DefaultState' );		
+		
+		$this->assertInstanceOf( DefaultState::class, $user->state, 'Casted object should be instanceof DefaultState' );
 	}
-
+	
 	public function testFluentMeta() {
 		$user = new UserTest;
 

tests/Models/UserTest.php

@@ -21,7 +21,7 @@ class UserTest extends Model
 	public $hideMeta = false;
 
 	public $disableFluentMeta = false;
-
+	
 	protected $casts = [
 		'state' => State::class,
 	];

tests/Traits/HasUserStates.php

@@ -3,53 +3,50 @@
 namespace Kodeine\Metable\Tests\Traits;
 
 use Kodeine\Metable\Tests\Casts\UserState\State;
+use Kodeine\Metable\Tests\Casts\UserCastedObject;
 
 trait HasUserStates
 {
 	public $casted = [
 		'state' => State::class,
 	];
-
-	public static function bootHasUserCasts()
-	{
-		self::creating( function ( $model ) {
+	
+	public static function bootHasUserCasts() {
+		self::creating( function ($model) {
 			$model->setDefaultCastedProperties();
 		} );
 	}
-
-	public function initializeHasUserCasts()
-	{
+	
+	public function initializeHasUserCasts() {
 		$this->setDefaultCastedProperties();
 	}
-
-	private function getStateConfigs()
-	{
+	
+	private function getStateConfigs() {
 		$casts = $this->getCasts();
 
 		$states = [];
-
+		
 		foreach ($casts as $prop => $state) {
-			if (! is_subclass_of($state, UserCastedObject::class)) {
+			if ( ! is_subclass_of( $state, UserCastedObject::class ) ) {
 				continue;
 			}
-
+			
 			$states[$prop] = $state::config();
 		}
-
+		
 		return $states;
 	}
-
-	private function setDefaultCastedProperties() 
-	{
-		foreach ( $this->getStateConfigs() as $prop => $config ) {
-			if ($this->{$prop} === null) {
+	
+	private function setDefaultCastedProperties() {
+		foreach ($this->getStateConfigs() as $prop => $config) {
+			if ( $this->{$prop} === null ) {
 				continue;
 			}
-
+			
 			if ( ! isset( $config['default'] ) ) {
 				continue;
 			}
-
+			
 			$this->{$prop} = $config['default'];
 		}
 	}