issueContent without prior call to getContentMetadata

[jabbors]

It appears some reading devices (Victor Stream Reader and Webbox2) caches the result from getContentMetadata for optimization, so in some cases there might be a call to issueContent without a prior call to getContentMetatdata.

Although the specification clearly states that getContentMetadata must be called, it is arguable if it's necessary or not.

The intention of Kolibre-KADOS is to be 100% fully compatible with the written standard. Hence it is enforced that a reading system always calls getContentMetadata before issueContent.

However, it can be disabled with the below change to the source code.

diff --git a/include/DaisyOnlineService.class.php b/include/DaisyOnlineService.class.php
index 4548fa3..c426757 100644
--- a/include/DaisyOnlineService.class.php
+++ b/include/DaisyOnlineService.class.php
@@ -768,12 +768,12 @@ class DaisyOnlineService
         }
 
         // check if a prior call to getContentMetadata has been made
-        if (!$this->sessionHandleDisabled && in_array($contentId, $this->sessionContentMetadataRequests) === false)
-        {
-            $this->logger->warn("No prior call to getContentMetadata for content '$contentId'");
-            $faultString = "Metadata for content has not been requested, call getContentMetadata for content '$contentId'";
-            throw new SoapFault('Client', $faultString, '', '', 'issueContent_invalidOperationFault');
-        }
+        // if (!$this->sessionHandleDisabled && in_array($contentId, $this->sessionContentMetadataRequests) === false)
+        // {
+        //     $this->logger->warn("No prior call to getContentMetadata for content '$contentId'");
+        //     $faultString = "Metadata for content has not been requested, call getContentMetadata for content '$contentId'";
+        //     throw new SoapFault('Client', $faultString, '', '', 'issueContent_invalidOperationFault');
+        // }
 
         // check if content is issuable and issue content
         try