Skip to content

Commit 2d74749

Browse files
committed
cleanup and add comment
1 parent b9e1918 commit 2d74749

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

pkg/osquery/runtime/runner.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,8 @@ func (r *Runner) InstanceStatuses() map[string]types.InstanceStatus {
369369
return instanceStatuses
370370
}
371371

372+
// UpdateRegistrationIDs detects any changes between the new and stored registration IDs,
373+
// and resets the runner instances for the new registrationIDs if required
372374
func (r *Runner) UpdateRegistrationIDs(newRegistrationIDs []string) error {
373375
slices.Sort(newRegistrationIDs)
374376
existingRegistrationIDs := r.registrationIds

pkg/osquery/runtime/runtime_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ func TestMultipleInstancesWithUpdatedRegistrationIDs(t *testing.T) {
674674

675675
waitShutdown(t, runner, logBytes)
676676

677-
// Confirm both instances exited
677+
// Confirm instance exited
678678
require.Contains(t, runner.instances, types.DefaultRegistrationID)
679679
require.NotNil(t, runner.instances[types.DefaultRegistrationID].stats)
680680
require.NotEmpty(t, runner.instances[types.DefaultRegistrationID].stats.ExitTime, "exit time should be added to default instance stats on shutdown")

0 commit comments

Comments
 (0)