style: enabled no-console eslint rule (#DS-2920) (#1104)

Author: artembelik

.eslintrc.js

@@ -115,6 +115,7 @@ const javascriptAndTypescriptRules = {
         'no-useless-escape': 0,
         'no-self-assign': 0,
         'no-prototype-builtins': 0,
+        'no-console': 1,
 
         // plugin:promise
         'promise/catch-or-return': 0,
@@ -253,6 +254,7 @@ const componentsDevRules = {
             1,
             ...noRestrictedGlobalsOptionsForSSR
         ],
+        'no-console': 0,
 
         // plugin:@angular-eslint
         '@angular-eslint/directive-selector': [
@@ -295,6 +297,7 @@ const componentsExamplesRules = {
             1,
             ...noRestrictedGlobalsOptionsForSSR
         ],
+        'no-console': 0,
 
         // plugin:@angular-eslint
         '@angular-eslint/prefer-standalone': 1,
@@ -379,6 +382,45 @@ const specRules = {
     }
 };
 
+/**
+ * Override rules for /tools
+ *
+ * @type {import('eslint').Linter.ConfigOverride}
+ */
+const toolsRules = {
+    files: ['tools/**/*.ts', 'tools/**/*.js'],
+    rules: {
+        // plugin:eslint
+        'no-console': 0
+    }
+};
+
+/**
+ * Override rules for /packages/schematics/
+ *
+ * @type {import('eslint').Linter.ConfigOverride}
+ */
+const schematicsRules = {
+    files: ['packages/schematics/**/*.ts', 'packages/schematics/**/*.js'],
+    rules: {
+        // plugin:eslint
+        'no-console': 0
+    }
+};
+
+/**
+ * Override rules for /packages/cli/
+ *
+ * @type {import('eslint').Linter.ConfigOverride}
+ */
+const cliRules = {
+    files: ['packages/cli/**/*.ts', 'packages/cli/**/*.js'],
+    rules: {
+        // plugin:eslint
+        'no-console': 0
+    }
+};
+
 /** @type {import('eslint').Linter.ConfigOverride} */
 const prettierRules = {
     files: ['*.js', '*.ts', '*.html'],
@@ -416,6 +458,9 @@ const config = {
         componentsExamplesRules,
         componentsRules,
         specRules,
+        toolsRules,
+        schematicsRules,
+        cliRules,
         // should be last
         prettierRules
     ]

apps/docs/scripts/build-tokens.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 const StyleDictionary = require('style-dictionary');
 const getPlatformConfig = require('@koobiq/tokens-builder/configs/index.js');
 

packages/components/app-switcher/app-switcher.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { OverlayContainer } from '@angular/cdk/overlay';
 import { Component, DebugElement, Provider, Type } from '@angular/core';
 import { ComponentFixture, TestBed, fakeAsync, inject } from '@angular/core/testing';

packages/components/code-block/code-block-highlight.ts

@@ -56,6 +56,7 @@ export class KbqCodeBlockHighlight {
         let { language } = file;
 
         if (!language || !hljs.getLanguage(language)) {
+            // eslint-disable-next-line no-console
             console.warn(
                 `[KbqCodeBlock] Unknown file language: "${language}". Fall back to "${this.fallbackFileLanguage}".`,
                 file
@@ -73,10 +74,12 @@ export class KbqCodeBlockHighlight {
         });
 
         if (illegal) {
+            // eslint-disable-next-line no-console
             console.warn('[KbqCodeBlock] File content contains illegal characters.', file);
         }
 
         if (relevance === 0) {
+            // eslint-disable-next-line no-console
             console.warn('[KbqCodeBlock] File content does not match the specified programming language.', file);
         }
 
@@ -137,6 +140,7 @@ export class KbqCodeBlockHighlight {
 
             addStyles();
         } else {
+            // eslint-disable-next-line no-console
             console.error('highlight.js not detected!');
         }
 
@@ -298,6 +302,7 @@ export class KbqCodeBlockHighlight {
                     }
                 }
             } catch (e) {
+                // eslint-disable-next-line no-console
                 console.error('LineNumbers error: ', e);
             }
         }

packages/components/core/common-behaviors/color.ts

@@ -75,6 +75,7 @@ export function mixinColor<T extends Constructor<HasElementRef>>(
 
             this.color = defaultColor;
 
+            // eslint-disable-next-line no-console
             console.warn('mixinColor deprecated and will be deleted in next major release');
         }
     };

packages/components/core/common-behaviors/common-module.ts

@@ -62,6 +62,7 @@ export class KbqCommonModule {
 
     private checkDoctypeIsDefined(): void {
         if (this.document && !this.document.doctype) {
+            // eslint-disable-next-line no-console
             console.warn(
                 'Current document does not have a doctype. This may cause ' +
                     'some koobiq components not to behave as expected.'

packages/components/core/common-behaviors/disabled.ts

@@ -27,6 +27,7 @@ export function mixinDisabled<T extends Constructor<{}>>(base: T): CanDisableCto
         constructor(...args: any[]) {
             super(...args);
 
+            // eslint-disable-next-line no-console
             console.warn('mixinDisabled deprecated and will be deleted in next major release');
         }
     };

packages/components/core/common-behaviors/error-state.ts

@@ -41,6 +41,7 @@ export function mixinErrorState<T extends Constructor<HasErrorState>>(base: T):
         constructor(...args: any[]) {
             super(...args);
 
+            // eslint-disable-next-line no-console
             console.warn('mixinErrorState deprecated and will be deleted in next major release');
         }
 

packages/components/core/common-behaviors/tabindex.ts

@@ -33,6 +33,7 @@ export function mixinTabIndex<T extends Constructor<CanDisable>>(base: T, defaul
         constructor(...args: any[]) {
             super(...args);
 
+            // eslint-disable-next-line no-console
             console.warn('mixinTabIndex deprecated and will be deleted in next major release');
         }
     };

packages/components/core/pop-up/pop-up-trigger.ts

@@ -179,6 +179,7 @@ export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
         } else {
             this.placement = PopUpPlacements.Top;
 
+            // eslint-disable-next-line no-console
             console.warn(`Unknown position: ${value}. Will used default position: ${this.placement}`);
         }