chore: fix release notification (#DS-5129)

Author: lskramarov

.github/workflows/publish.yml

@@ -34,4 +34,3 @@ jobs:
           NPM_TOKEN_KOOBIQ: ${{ secrets.NPM_PUBLISH_TOKEN }}
           MATTERMOST_WEBHOOK_URL: ${{ secrets.MM_WEBHOOK_URL }}
           MATTERMOST_CHANNEL: ${{ secrets.MM_CHANNEL_NAME }}
-          MATTERMOST_USERNAME: ${{ secrets.MM_BOT_NAME }}

packages/cli/src/release/notify-release.ts

@@ -1,40 +1,85 @@
 import chalk from 'chalk';
+import { request as httpsRequest } from 'https';
 import { ChangelogReleaseNotes } from './extract-release-notes';
 
-const { green, red, cyan } = chalk;
+const { cyan, green, red } = chalk;
 
 type MattermostConfig = {
     url: string;
     channel: string;
-    username: string;
 };
 
 function getMattermostConfig(): MattermostConfig | null {
     const url = process.env['MATTERMOST_WEBHOOK_URL'];
     const channel = process.env['MATTERMOST_CHANNEL'];
-    const username = process.env['MATTERMOST_USERNAME'];
 
-    if (!url || !channel || !username) {
+    if (!url || !channel) {
         return null;
     }
 
-    return { url, channel, username };
+    return { url, channel };
 }
 
+// Use https.request (not fetch/undici) — the Mattermost webhook is behind a WAF
+// that blocks requests by TLS fingerprint / HTTP/2. The Node built-in HTTP stack
+// (HTTP/1.1 + standard TLS) is the same one @actions/http-client uses and passes
+// the WAF. Don't "modernize" this back to fetch without re-checking the WAF.
 async function sendNotification(url: string, body: object): Promise<void> {
-    const headers: Record<string, string> = { 'Content-Type': 'application/json' };
-    const requestOptions: RequestInit = {
-        method: 'POST',
-        headers,
-        body: JSON.stringify(body)
+    const payload = JSON.stringify(body);
+    const headers: Record<string, string> = {
+        'Content-Type': 'application/json; charset=utf-8',
+        Accept: 'application/json',
+        'Content-Length': Buffer.byteLength(payload).toString()
     };
 
-    console.info(cyan('POST notification:'), { headers, body: JSON.stringify(body) });
-
-    const response = await fetch(url, requestOptions);
-
-    if (!response.ok) {
-        throw new Error(`Failed to post notification: ${response.status} ${response.statusText}`);
+    console.info(cyan('  [DEBUG] HTTP request:'), {
+        method: 'POST',
+        url,
+        headers,
+        body: payload
+    });
+
+    const parsed = new URL(url);
+    const { statusCode, statusMessage, responseBody } = await new Promise<{
+        statusCode: number;
+        statusMessage: string;
+        responseBody: string;
+    }>((resolve, reject) => {
+        const req = httpsRequest(
+            {
+                method: 'POST',
+                hostname: parsed.hostname,
+                port: parsed.port || undefined,
+                path: parsed.pathname + parsed.search,
+                headers
+            },
+            (res) => {
+                let data = '';
+
+                res.setEncoding('utf8');
+                res.on('data', (chunk: string) => {
+                    data += chunk;
+                });
+                res.on('end', () => {
+                    resolve({
+                        statusCode: res.statusCode ?? 0,
+                        statusMessage: res.statusMessage ?? '',
+                        responseBody: data
+                    });
+                });
+            }
+        );
+
+        req.on('error', reject);
+        req.write(payload);
+        req.end();
+    });
+
+    console.info(cyan(`  [DEBUG] HTTP response: ${statusCode} ${statusMessage}`));
+
+    if (statusCode < 200 || statusCode >= 300) {
+        console.error(red(`  ✘   Mattermost response body: ${responseBody}`));
+        throw new Error(`Failed to post notification: ${statusCode} ${statusMessage}`);
     }
 }
 
@@ -67,8 +112,8 @@ export async function notify(releaseData: ChangelogReleaseNotes): Promise<void>
     }
 
     const body = {
-        channel: `${config.channel}`,
-        username: `${config.username}`,
+        channel: config.channel,
+        username: 'Wall-e',
         text: `${releaseData.releaseTitle}\n${releaseData.releaseNotes}`
     };