Fixed a few warnings

Author: fabmax

buildSrc/src/main/kotlin/kool.lib-conventions.gradle.kts

@@ -23,6 +23,7 @@ kotlin {
     compilerOptions {
         freeCompilerArgs.add("-opt-in=kotlin.RequiresOptIn")
         freeCompilerArgs.add("-Xcontext-parameters")
+        freeCompilerArgs.add("-Xexplicit-backing-fields")
     }
 
     sourceSets.all {

gradle/libs.versions.toml

@@ -30,6 +30,7 @@ kotlin-atomicfu = { group = "org.jetbrains.kotlinx", name = "atomicfu", version.
 kotlin-test = { group = "org.jetbrains.kotlin", name = "kotlin-test", version.ref = "kotlin" }
 kotlin-test-junit = { group = "org.jetbrains.kotlin", name = "kotlin-test-junit", version.ref = "kotlin" }
 jsvg = { group = "com.github.weisj", name = "jsvg", version.ref = "jsvg" }
+jspecify-annotations = { module = "org.jspecify:jspecify", version = "1.0.0" }
 androidsvg = { group = "com.caverock", name = "androidsvg-aar", version.ref = "androidsvg" }
 lwjgl-core = { group = "org.lwjgl", name = "lwjgl", version.ref = "lwjgl" }
 lwjgl-glfw = { group = "org.lwjgl", name = "lwjgl-glfw", version.ref = "lwjgl" }

kool-core/build.gradle.kts

@@ -30,6 +30,7 @@ kotlin {
                     .filter { it.name !in nonNativeLibs }
                     .forEach { lib -> runtimeOnly("$lib:$platform") }
             }
+            compileOnly(libs.jspecify.annotations)   // used / needed by lwjgl
         }
         desktopTest.dependencies {
             implementation(libs.kotlin.test.junit)

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/gltf/GltfMaterial.kt

@@ -150,7 +150,7 @@ data class GltfMaterial(
                     }
                     textureProperty(roughnessTexture, 0, texName)
                 }
-                val occlusionFactor = this@GltfMaterial.occlusionTexture?.strength ?: 1f
+                val occlusionFactor = this@GltfMaterial.occlusionTexture.strength
                 if (occlusionFactor != 1f) {
                     constProperty(occlusionFactor, blendMode = PropertyBlockConfig.BlendMode.Multiply)
                 }

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/ui2/LaunchedEffect.kt

@@ -5,7 +5,7 @@ import kotlinx.coroutines.Job
 import kotlinx.coroutines.launch
 
 /**
- * Runs a coroutine when entering the composition and relaunches it when [key1] changes.
+ * Runs a coroutine when entering the composition and relaunches it when [keys] change.
  * Useful for triggering suspend operations (e.g. animations) in response to state updates.
  */
 fun UiScope.LaunchedEffect(vararg keys: Any?, block: suspend CoroutineScope.() -> Unit) {

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/ui2/UiAnimations.kt

@@ -11,6 +11,7 @@ fun UiScope.animateFloatAsState(
 ): MutableStateValue<Float> {
     val animatable = remember { AnimatableFloat(targetValue) }
     LaunchedEffect(targetValue) {
+
         animationSpec.animateTo(animatable, targetValue)
     }
     return animatable

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/ui2/UiScope.kt

@@ -17,7 +17,7 @@ interface UiScope {
     val Int.dp: Dp get() = Dp(this.toFloat())
     val Float.dp: Dp get() = Dp(this)
 
-    fun <T: Any?> MutableStateValue<T>.use(): T = use(surface)
+    fun <T> MutableStateValue<T>.use(): T = use(surface)
     fun <T> MutableStateList<T>.use(): MutableStateList<T> = use(surface)
 
     fun <T: Any> AnimatedState<T>.progressAndUse(): T {
@@ -29,10 +29,10 @@ interface UiScope {
         compose()
     }
 
-    operator fun <T: Any?> MutableStateValue<T>.getValue(thisRef: Any?, property: KProperty<*>): T = use(surface)
-    operator fun <T: Any?> MutableStateValue<T>.setValue(thisRef: Any?, property: KProperty<*>, value: T) = set(value)
+    operator fun <T> MutableStateValue<T>.getValue(thisRef: Any?, property: KProperty<*>): T = use(surface)
+    operator fun <T> MutableStateValue<T>.setValue(thisRef: Any?, property: KProperty<*>, value: T) = set(value)
 
-    operator fun <T: Any?> MutableStateList<T>.getValue(thisRef: Any?, property: KProperty<*>): MutableStateList<T> = use(surface)
+    operator fun <T> MutableStateList<T>.getValue(thisRef: Any?, property: KProperty<*>): MutableStateList<T> = use(surface)
 }
 
 inline fun UiScope.Popup(
@@ -57,7 +57,7 @@ inline fun UiScope.Popup(
 }
 
 inline fun <reified T: Any> UiScope.remember(provider: () -> T): T = uiNode.weakMemory.weakMemory(provider)
-fun <T: Any?> UiScope.remember(initialState: T): MutableStateValue<T> = remember { mutableStateOf(initialState) }
-fun <T: Any?> UiScope.remember(initialState: T, onChange: (T, T) -> Unit) = remember { mutableStateOf(initialState).onChange(onChange) }
+fun <T> UiScope.remember(initialState: T): MutableStateValue<T> = remember { mutableStateOf(initialState) }
+fun <T> UiScope.remember(initialState: T, onChange: (T, T) -> Unit) = remember { mutableStateOf(initialState).onChange(onChange) }
 fun UiScope.rememberScrollState(): ScrollState = remember { ScrollState() }
 fun UiScope.rememberListState(): LazyListState = remember { LazyListState() }

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/ui2/WeakMemory.kt

@@ -37,7 +37,7 @@ class WeakMemory {
                 nextEntry++
                 val newEntry = provider()
                 entries += newEntry
-                return newEntry
+                newEntry
             }
         }
     }

kool-core/src/commonMain/kotlin/de/fabmax/kool/modules/ui2/docking/DockNode.kt

@@ -128,7 +128,7 @@ sealed class DockNode(
             relevantChild = relevantParent
             relevantParent = relevantParent.parent
         }
-        (relevantParent as DockNodeRow?)?.moveEdgeTo(relevantChild.index, screenX)
+        relevantParent?.moveEdgeTo(relevantChild.index, screenX)
     }
 
     fun moveRightEdgeTo(screenX: Float) {
@@ -139,7 +139,7 @@ sealed class DockNode(
             relevantChild = relevantParent
             relevantParent = relevantParent.parent
         }
-        (relevantParent as DockNodeRow?)?.moveEdgeTo(relevantChild.index + 1, screenX)
+        relevantParent?.moveEdgeTo(relevantChild.index + 1, screenX)
     }
 
     fun moveTopEdgeTo(screenY: Float) {
@@ -150,7 +150,7 @@ sealed class DockNode(
             relevantChild = relevantParent
             relevantParent = relevantParent.parent
         }
-        (relevantParent as DockNodeColumn?)?.moveEdgeTo(relevantChild.index, screenY)
+        relevantParent?.moveEdgeTo(relevantChild.index, screenY)
     }
 
     fun moveBottomEdgeTo(screenY: Float) {
@@ -161,7 +161,7 @@ sealed class DockNode(
             relevantChild = relevantParent
             relevantParent = relevantParent.parent
         }
-        (relevantParent as DockNodeColumn?)?.moveEdgeTo(relevantChild.index + 1, screenY)
+        relevantParent?.moveEdgeTo(relevantChild.index + 1, screenY)
     }
 
     fun <T: DockNode> countParentsOfType(nodeType: KClass<T>): Int {

kool-core/src/commonMain/kotlin/de/fabmax/kool/util/PolyUtil.kt

@@ -159,7 +159,7 @@ object PolyUtil {
         private fun nextEarTip(): PolyVertex? {
             var best: PolyVertex? = null
             verts.forEach { v ->
-                if (v.isOpen && v.isEar && (best == null || best!!.interiorAngle > v.interiorAngle)) {
+                if (v.isOpen && v.isEar && (best == null || best.interiorAngle > v.interiorAngle)) {
                     best = v
                 }
             }