xplat: make DynamicProfileStorage::Initialize re-entrant

kphillisjr · kphillisjr · commit b45d0b5b9886 · 2016-11-30T05:07:01.000-06:00
There is no reason for xplat to have this function be non-reentrant. This also reduces the number of code changes in issue chakra-core#1811 since this change fixes the issue with running ch. v2: use ifdef, since this call is ran on windows.
diff --git a/lib/Runtime/Language/DynamicProfileStorage.cpp b/lib/Runtime/Language/DynamicProfileStorage.cpp
@@ -296,7 +296,9 @@ char16 const * DynamicProfileStorage::GetMessageType()
 
 bool DynamicProfileStorage::Initialize()
 {
+#ifdef _WIN32
     AssertMsg(!initialized, "Initialize called multiple times");
+#endif
     if (initialized)
     {
         return true;

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,9 @@ char16 const * DynamicProfileStorage::GetMessageType()`
`296`	`296`
`297`	`297`	`bool DynamicProfileStorage::Initialize()`
`298`	`298`	`{`
	`299`	`+#ifdef _WIN32`
`299`	`300`	`AssertMsg(!initialized, "Initialize called multiple times");`
	`301`	`+#endif`
`300`	`302`	`if (initialized)`
`301`	`303`	`{`
`302`	`304`	`return true;`