Added tests for DI extension.

Author: kriswallsmith

DependencyInjection/TwitterExtension.php

@@ -15,8 +15,7 @@ class TwitterExtension extends Extension
     public function apiLoad($config, ContainerBuilder $container)
     {
         if (!$container->hasDefinition('kris.twitter')) {
-            $loader = new XmlFileLoader($container, __DIR__.'/../Resources/config');
-            $loader->load($this->resources['twitter']);
+            $this->loadDefaults($container);
         }
 
         if (isset($config['alias'])) {
@@ -30,18 +29,36 @@ public function apiLoad($config, ContainerBuilder $container)
         }
     }
 
+    /**
+     * @codeCoverageIgnore
+     */
     public function getXsdValidationBasePath()
     {
         return __DIR__.'/../Resources/config/schema';
     }
 
+    /**
+     * @codeCoverageIgnore
+     */
     public function getNamespace()
     {
         return 'http://kriswallsmith.net/schema/dic/twitter';
     }
 
+    /**
+     * @codeCoverageIgnore
+     */
     public function getAlias()
     {
         return 'twitter';
     }
+
+    /**
+     * @codeCoverageIgnore
+     */
+    protected function loadDefaults($container)
+    {
+        $loader = new XmlFileLoader($container, __DIR__.'/../Resources/config');
+        $loader->load($this->resources['twitter']);
+    }
 }

Tests/DependencyInjection/TwitterExtensionTest.php

@@ -0,0 +1,106 @@
+<?php
+
+namespace Bundle\Kris\TwitterBundle\Tests\DependencyInjection;
+
+use Bundle\Kris\TwitterBundle\DependencyInjection\TwitterExtension;
+
+class TwitterExtensionTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @covers Bundle\Kris\TwitterBundle\DependencyInjection\TwitterExtension::apiLoad
+     */
+    public function testApiLoadLoadsDefaults()
+    {
+        $container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerBuilder');
+        $container
+            ->expects($this->once())
+            ->method('hasDefinition')
+            ->with('kris.twitter')
+            ->will($this->returnValue(false));
+
+        $extension = $this->getMockBuilder('Bundle\\Kris\\TwitterBundle\\DependencyInjection\\TwitterExtension')
+            ->setMethods(array('loadDefaults'))
+            ->getMock();
+        $extension
+            ->expects($this->once())
+            ->method('loadDefaults')
+            ->with($container);
+
+        $extension->apiLoad(array(), $container);
+    }
+
+    /**
+     * @covers Bundle\Kris\TwitterBundle\DependencyInjection\TwitterExtension::apiLoad
+     */
+    public function testApiLoadDoesNotReloadDefaults()
+    {
+        $container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerBuilder');
+        $container
+            ->expects($this->once())
+            ->method('hasDefinition')
+            ->with('kris.twitter')
+            ->will($this->returnValue(true));
+
+        $extension = $this->getMockBuilder('Bundle\\Kris\\TwitterBundle\\DependencyInjection\\TwitterExtension')
+            ->setMethods(array('loadDefaults'))
+            ->getMock();
+        $extension
+            ->expects($this->never())
+            ->method('loadDefaults');
+
+        $extension->apiLoad(array(), $container);
+    }
+
+    /**
+     * @covers Bundle\Kris\TwitterBundle\DependencyInjection\TwitterExtension::apiLoad
+     */
+    public function testApiLoadSetsAlias()
+    {
+        $alias = 'foo';
+
+        $container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerBuilder');
+        $container
+            ->expects($this->once())
+            ->method('hasDefinition')
+            ->with('kris.twitter')
+            ->will($this->returnValue(true));
+        $container
+            ->expects($this->once())
+            ->method('setAlias')
+            ->with($alias, 'kris.twitter');
+
+        $extension = new TwitterExtension();
+        $extension->apiLoad(array('alias' => $alias), $container);
+    }
+
+    /**
+     * @covers Bundle\Kris\TwitterBundle\DependencyInjection\TwitterExtension::apiLoad
+     * @dataProvider parameterNames
+     */
+    public function testApiLoadSetParameters($name)
+    {
+        $value = 'foo';
+
+        $container = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerBuilder');
+        $container
+            ->expects($this->once())
+            ->method('hasDefinition')
+            ->with('kris.twitter')
+            ->will($this->returnValue(true));
+        $container
+            ->expects($this->once())
+            ->method('setParameter')
+            ->with('kris.twitter.'.$name, $value);
+
+        $extension = new TwitterExtension();
+        $extension->apiLoad(array($name => $value), $container);
+    }
+
+    public function parameterNames()
+    {
+        return array(
+            array('consumer_key'),
+            array('consumer_secret'),
+        );
+    }
+}