Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Tag releases on github #199

Open
ignatenkobrain opened this issue Aug 9, 2020 · 8 comments
Open

RFE: Tag releases on github #199

ignatenkobrain opened this issue Aug 9, 2020 · 8 comments

Comments

@ignatenkobrain
Copy link
Contributor

It would be cool if you would make commit for each release automation does (basically changes to galaxy.yml) and tag it so that mere people that want to package collection could easily do it from github.

@ktdreyer
Copy link
Owner

Thanks for this suggestion. I'm wondering about the use-case. Can you say more about how users would make use of this?

I would like to avoid publishing hundreds of Git tags, essentially tagging every time we update master. That's a lot of extra refs for every Git client to fetch over time.

Can you use the output from git rev-list --count $BASE_COMMIT..HEAD like we do for ./build-collection and .copr/Makefile ?

@ignatenkobrain
Copy link
Contributor Author

Not automatically. The context here is the packaging this collection in Fedora repositories which means no access to the internet.

@ktdreyer
Copy link
Owner

Oh ok. In that case, can you use the Galaxy tarballs that we upload?

For example: https://galaxy.ansible.com/download/ktdreyer-koji_ansible-0.0.367.tar.gz

See Source0 in the .spec file template for Copr.

@ignatenkobrain
Copy link
Contributor Author

@ktdreyer no, they are not enough...

@ktdreyer
Copy link
Owner

Would you please say what they are missing?

@ignatenkobrain
Copy link
Contributor Author

@ktdreyer the FILES.json and everything else is already prepared on your machine, so for instance if we would like to apply any patch (that would not be possible to upstream so that we have to keep it downstream) would require some tricky modifications to the jsons instead of just running ansible-galaxy collection build.

Also github has very nice feature that it notifies about tags/releases so (in case of downstream) we would subscribe and get those notifications. I'm not aware of anything like that from ansible galaxy.

@ktdreyer
Copy link
Owner

ktdreyer commented Jun 9, 2021

Thanks for explaining.

GitHub prepares FILES.json automatically (GitHub Actions runs the build-collection script.) I wonder if there's a way to do that in the RPM so it's easier to patch. It would be nice to just run ansible-galaxy collection build like you mention.

For version monitoring, there is a JSON API at https://galaxy.ansible.com/api/v2/collections/ktdreyer/koji_ansible/ . I've added it to https://release-monitoring.org/project/211000/

@ignatenkobrain
Copy link
Contributor Author

Well, if I download archive from github I can run ansivlegalaxy build myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants