Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multicall for performance #30

Open
ktdreyer opened this issue Feb 8, 2019 · 2 comments
Open

use multicall for performance #30

ktdreyer opened this issue Feb 8, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ktdreyer
Copy link
Owner

ktdreyer commented Feb 8, 2019

As we add more features to koji_tag, we're making more and more XML-RPC calls, and this is slowing down the playbook operation.

We should be able to get all the information we need about the tag in one single "read" multicall, and then we can make all the changes we need in another single "write" multicall.

@ktdreyer ktdreyer added the enhancement New feature or request label Feb 8, 2019
@mizdebsk
Copy link
Collaborator

It is probably not possible to do everything it just two multicall calls. For example, some calls require passing tag ID, but you don't know that until tag is created. But it should be possible to group everything into a few RPC calls.

mizdebsk added a commit to mizdebsk/koji-ansible that referenced this issue May 22, 2019
@ktdreyer
Copy link
Owner Author

I played around with multicall recently and improved the upstream docs at https://pagure.io/koji/pull-request/3226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants