Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add to the context menu #16

Open
vitaly-zdanevich opened this issue Mar 8, 2024 · 1 comment
Open

[feature request] add to the context menu #16

vitaly-zdanevich opened this issue Mar 8, 2024 · 1 comment
Labels
question Further information is requested

Comments

@vitaly-zdanevich
Copy link
Contributor

Like this
image

Maybe I will try to implement this, if ok.

@kuanyui
Copy link
Owner

kuanyui commented Mar 9, 2024

Sounds good, but:

  1. I think this is somewhat out of scope of this extension (After all, this extension is for "one click to switch between engines with the same keyword"). What more important is, there are already multiple WebExtensions are specially designed to do this task, for example, the Trufflepiggy you mentioned? It even provides more and more engines already. (Though, the only reason I can think of is 1. for those who don't want to install too many WebExtensions if possible, 2. FLOSS?)

  2. Don't sure if contextMenu can be hidden via option_ui (I didn't tried before) for those who don't need this feature and don't want the contextMenu too many unused items...?
    I had ever used only browser.menus.create() before, don't sure if browser.menus.removeAll() can do this. Need some experiment. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus

  3. A last but not the least note, FireFox Android doesn't support browser.menus APIs, need to handle this specially and test on Android. (If my memory serves me right, something like if (browser.menus !== undefined) { /* setup menus... */ })

@kuanyui kuanyui added the question Further information is requested label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants