Skip to content

Commit de4fabd

Browse files
committed
chore: add cleanup jobs for kind workflows
Signed-off-by: sduvvuri1603 <[email protected]>
1 parent 2178a23 commit de4fabd

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed

.github/workflows/e2e-test-frontend.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,11 @@ jobs:
7373
- name: Collect failed logs
7474
if: ${{ steps.deploy.outcome != 'success' || steps.forward-frontend-port.outcome != 'success' || steps.tests.outcome != 'success' }}
7575
run: |
76-
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
76+
if kubectl get namespace kubeflow >/dev/null 2>&1; then
77+
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
78+
else
79+
echo "kubeflow namespace not found; skipping log collection."
80+
fi
7781
exit 1
7882
7983
- name: Collect test results

.github/workflows/integration-tests-v1.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,11 @@ jobs:
8888
- name: Collect failed logs
8989
if: ${{ steps.forward-mysql-port.outcome != 'success' || steps.integration-tests.outcome != 'success' || steps.initialization-tests.outcome != 'success' }}
9090
run: |
91-
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
91+
if kubectl get namespace kubeflow >/dev/null 2>&1; then
92+
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
93+
else
94+
echo "kubeflow namespace not found; skipping log collection."
95+
fi
9296
exit 1
9397
9498
- name: Collect test results

.github/workflows/kfp-webhooks.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,11 @@ jobs:
5959
- name: Collect failed logs
6060
if: ${{ steps.create-kfp-cluster.outcome != 'success' || steps.deploy.outcome != 'success' || steps.tests.outcome != 'success' }}
6161
run: |
62-
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
62+
if kubectl get namespace kubeflow >/dev/null 2>&1; then
63+
./.github/resources/scripts/collect-logs.sh --ns kubeflow --output /tmp/tmp_pod_log.txt
64+
else
65+
echo "kubeflow namespace not found; skipping log collection."
66+
fi
6367
exit 1
6468
6569
- name: Collect test results

backend/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ RUN echo "Building for architecture: ${TARGETARCH}"
3939

4040
# Downloading Argo CLI so that the samples are validated
4141
ENV ARGO_VERSION=v3.7.3
42-
RUN curl -sLO https://github.com/argoproj/argo-workflows/releases/download/${ARGO_VERSION}/argo-linux-$TARGETARCH.gz && \
42+
RUN curl -sL -H "Accept: application/octet-stream" \
43+
https://github.com/argoproj/argo-workflows/releases/download/${ARGO_VERSION}/argo-linux-$TARGETARCH.gz \
44+
-o argo-linux-$TARGETARCH.gz && \
4345
gunzip argo-linux-$TARGETARCH.gz && \
4446
chmod +x argo-linux-$TARGETARCH && \
4547
mv ./argo-linux-$TARGETARCH /usr/local/bin/argo

test/release/Dockerfile.release

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,6 @@ RUN chmod -R 777 $NVM_DIR && \
4949
# Configure npm cache location
5050
RUN npm config set cache /tmp/.npm --global
5151

52-
RUN curl -L https://github.com/orhun/git-cliff/releases/download/v${GIT_CLIFF_VERSION}/git-cliff-${GIT_CLIFF_VERSION}-x86_64-unknown-linux-gnu.tar.gz \
52+
RUN curl -L -H "Accept: application/octet-stream" \
53+
https://github.com/orhun/git-cliff/releases/download/v${GIT_CLIFF_VERSION}/git-cliff-${GIT_CLIFF_VERSION}-x86_64-unknown-linux-gnu.tar.gz \
5354
| tar -xz --strip-components=1 -C /usr/local/bin git-cliff-${GIT_CLIFF_VERSION}/git-cliff

0 commit comments

Comments
 (0)