Address code review feedback: dispose GenericClient, use ternary operator, specific exception handling

Co-authored-by: tg123 <[email protected]>

Author: Copilot

src/KubernetesClient.Kubectl/Beta/AsyncKubectl.Get.cs

@@ -14,15 +14,10 @@ public async Task<T> GetAsync<T>(string name, string? @namespace = null, Cancell
         where T : IKubernetesObject
     {
         var metadata = typeof(T).GetKubernetesTypeMetadata();
-        var genericClient = new GenericClient(client, metadata.Group, metadata.ApiVersion, metadata.PluralName, disposeClient: false);
+        using var genericClient = new GenericClient(client, metadata.Group, metadata.ApiVersion, metadata.PluralName, disposeClient: false);
 
-        if (@namespace != null)
-        {
-            return await genericClient.ReadNamespacedAsync<T>(@namespace, name, cancellationToken).ConfigureAwait(false);
-        }
-        else
-        {
-            return await genericClient.ReadAsync<T>(name, cancellationToken).ConfigureAwait(false);
-        }
+        return @namespace != null
+            ? await genericClient.ReadNamespacedAsync<T>(@namespace, name, cancellationToken).ConfigureAwait(false)
+            : await genericClient.ReadAsync<T>(name, cancellationToken).ConfigureAwait(false);
     }
 }

tests/Kubectl.Tests/KubectlTests.Get.cs

@@ -1,3 +1,4 @@
+using k8s.Autorest;
 using k8s.E2E;
 using k8s.kubectl.beta;
 using k8s.Models;
@@ -71,9 +72,9 @@ public void GetPod()
             {
                 kubernetes.CoreV1.DeleteNamespacedPod(podName, namespaceParameter);
             }
-            catch
+            catch (HttpOperationException)
             {
-                // Ignore cleanup errors
+                // Ignore cleanup errors if pod was already deleted or doesn't exist
             }
         }
     }
@@ -131,9 +132,9 @@ public void GetService()
             {
                 kubernetes.CoreV1.DeleteNamespacedService(serviceName, namespaceParameter);
             }
-            catch
+            catch (HttpOperationException)
             {
-                // Ignore cleanup errors
+                // Ignore cleanup errors if service was already deleted or doesn't exist
             }
         }
     }
@@ -207,9 +208,9 @@ public void GetDeployment()
             {
                 kubernetes.AppsV1.DeleteNamespacedDeployment(deploymentName, namespaceParameter);
             }
-            catch
+            catch (HttpOperationException)
             {
-                // Ignore cleanup errors
+                // Ignore cleanup errors if deployment was already deleted or doesn't exist
             }
         }
     }