remove deprecated v1 provider id format #2122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/ibmcloud
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Amulyam24
reviewed
Jan 8, 2025
There was a problem hiding this comment.
@Prajyot-Parab, we need to remove the cluster-template-powervs also as we no longer use it
Ref - #1868
k8s-ci-robot
added
size/L
Amulyam24
reviewed
Jan 8, 2025
Karthik-K-N
reviewed
Jan 9, 2025
| @@ -1083,8 +1083,6 @@ func (m *MachineScope) SetProviderID(id *string) error { | |||
| return err | |||
| } | |||
| m.IBMVPCMachine.Spec.ProviderID = ptr.To(fmt.Sprintf("ibm://%s///%s/%s", accountID, m.Machine.Spec.ClusterName, *id)) | |||
| } else { | |||
There was a problem hiding this comment.
I think in main.go we have a check to make sure only v2 provider id is valid, So couple of things here
- Is if check at 1079 needed?
- If we keep if condition then if its not v2 format we should return error.
main.go
Outdated
| default: | ||
| return fmt.Errorf("invalid value for flag provider-id-fmt: %s, Supported values: %s, %s ", options.ProviderIDFormat, options.ProviderIDFormatV1, options.ProviderIDFormatV2) | ||
| } else { | ||
| return fmt.Errorf("invalid value for flag provider-id-fmt: %s, Supported values: %s ", options.ProviderIDFormat, options.ProviderIDFormatV2) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("invalid value for flag provider-id-fmt: %s, Supported values: %s ", options.ProviderIDFormat, options.ProviderIDFormatV2) | |
| return fmt.Errorf("invalid value for flag provider-id-fmt: %s, Only supported value is %s", options.ProviderIDFormat, options.ProviderIDFormatV2) |
Signed-off-by: Prajyot Parab <[email protected]>
|
/cc @mkumatag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1917
Special notes for your reviewer:
/area provider/ibmcloud
Release note: