-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to Shutdown VM before deleting it #1973
Comments
Sounds useful. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@shaardie sounds like useful indeed. Would you still be interested to implement it? /remove-lifecycle stale |
+1 |
Tries to shutdown the OpenStack VM before deleting it. This way even Pods form Daemonsets are shut down more gracefully and services like license daemons on the VMs can be properly shutdown. Related to kubernetes-sigs#1973, but implemented for an older version.
I would like to implement it, but unfortunately there is a big leap between main and the version we are currently using (0.9). Especially, because there seems to be a new controller. As a quick fix, at least for us, I implemented this on the release-0.9 branch. As soon as the dust settles and we can switch to a version near the current main, I would try to implement it there again. |
Tries to shutdown the OpenStack VM before deleting it. This way even Pods form Daemonsets are shut down more gracefully and services like license daemons on the VMs can be properly shutdown. Related to kubernetes-sigs#1973, but implemented for an older version.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/kind feature
Describe the solution you'd like
I think the teardown process of VMs would benefit from an option to shutdown the OpenStack Machine before deleting it. This way it would be possible to benefit from teardown process in the VMs itself. Myself encountered this problem with NVIDIA licensees, which are
borrowed
on VM startup, but never properly released, because the Service on the VM was never stopped properly and therefore had no chance of releasing the license.I think on way of implementing this, would be to add something like an
waitForShutdown
to the OpenStackMachine CRD. It could be defaulted to0s
to keep the old behavior and it would be a single configuration to have the possibility to let the VM properly shutdown and have a timeout for the shutdown, so that it does not hang forever in an error case.If you are interested in such a feature, I would be happy to help implementing it.
The text was updated successfully, but these errors were encountered: