Fix lint

Signed-off-by: Lubron Zhan <[email protected]>

Author: lubronzhan

api/v1beta1/zz_generated.conversion.go

@@ -587,12 +587,13 @@ type Topology struct {
 	Variables []ClusterVariable `json:"variables,omitempty"`
 
 	// nodeDeletionStrategy specifies the strategy to delete nodes in the cluster.
-	// Avilable options:
+	// Available options:
 	// - graceful
 	// - force
-	// By default it's "force"
+	// By default it's "force".
 	// +optional
-	NodeDeletionStrategy *NodeDrainStrategyType `json:"nodeDrainStrategy,omitempty"`
+	// +kubebuilder:validation:Enum=force;graceful
+	NodeDeletionStrategy *NodeDeletionStrategyType `json:"nodeDeletionStrategy,omitempty"`
 }
 
 // ControlPlaneTopology specifies the parameters for the control plane nodes in the cluster.
@@ -909,11 +910,14 @@ type MachinePoolVariables struct {
 	Overrides []ClusterVariable `json:"overrides,omitempty"`
 }
 
-type NodeDrainStrategyType string
+// NodeDeletionStrategyType defines type of NodeDeletionStrategy.
+type NodeDeletionStrategyType string
 
 const (
-	NodeDrainStrategyForce               NodeDrainStrategyType = "force"
-	NodeDrainStrategyGracefulWithTimeout NodeDrainStrategyType = "gracefulWithTimeout"
+	// NodeDeletionStrategyForce defines a force type strategy that node will be deleted immediately without drain.
+	NodeDeletionStrategyForce NodeDeletionStrategyType = "force"
+	// NodeDeletionStrategyTypeGracefulWithTimeout defines a force type strategy that node will be deleted with drain.
+	NodeDeletionStrategyGracefulWithTimeout NodeDeletionStrategyType = "gracefulWithTimeout"
 )
 
 // ANCHOR_END: ClusterSpec

api/v1beta2/cluster_types.go

@@ -715,7 +715,7 @@ func (r *Reconciler) nodeVolumeDetachTimeoutExceeded(machine *clusterv1.Machine)
 func (r *Reconciler) isDeleteNodeAllowed(ctx context.Context, cluster *clusterv1.Cluster, machine *clusterv1.Machine) error {
 	log := ctrl.LoggerFrom(ctx)
 	// Return early if the cluster is being deleted and cluster's nodeDeletionStrategy is not set or set to `force`.
-	if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology.NodeDeletionStrategy == nil || *cluster.Spec.Topology.NodeDeletionStrategy == clusterv1.NodeDrainStrategyForce) {
+	if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology.NodeDeletionStrategy == nil || *cluster.Spec.Topology.NodeDeletionStrategy == clusterv1.NodeDeletionStrategyForce) {
 		return errClusterIsBeingDeleted
 	}
 

api/v1beta2/zz_generated.deepcopy.go

@@ -2679,7 +2679,7 @@ func TestIsDeleteNodeAllowed(t *testing.T) {
 				},
 				Spec: clusterv1.ClusterSpec{
 					Topology: &clusterv1.Topology{
-						NodeDeletionStrategy: ptr.To(clusterv1.NodeDrainStrategyForce),
+						NodeDeletionStrategy: ptr.To(clusterv1.NodeDeletionStrategyForce),
 					},
 				},
 			},
@@ -2695,7 +2695,7 @@ func TestIsDeleteNodeAllowed(t *testing.T) {
 				},
 				Spec: clusterv1.ClusterSpec{
 					Topology: &clusterv1.Topology{
-						NodeDeletionStrategy: ptr.To(clusterv1.NodeDrainStrategyForce),
+						NodeDeletionStrategy: ptr.To(clusterv1.NodeDeletionStrategyForce),
 					},
 				},
 			},