Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error reporting to Temporary while Creating Volume #925

Open
riteshghorse opened this issue Aug 7, 2024 · 4 comments · Fixed by #924 · May be fixed by #971
Open

Change error reporting to Temporary while Creating Volume #925

riteshghorse opened this issue Aug 7, 2024 · 4 comments · Fixed by #924 · May be fixed by #971
Assignees
@riteshghorse
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@riteshghorse
Copy link
Contributor

When CreateVolume is called, the csi-provisioner expects either "final" or "temporary" errors. If we report final error when Filestore instance creation could be ongoing or it is already created, then a PVC deletion before successful volume creation could lead to resource leakage as DeleteVolume won't happen.

This is already done for gcp-compute-persistent-disk-csi-driver.

PRs:
@riteshghorse
Copy link
Contributor Author

/assign

@riteshghorse riteshghorse mentioned this issue Aug 7, 2024
Merged
@leiyiz
Copy link
Contributor

leiyiz commented Sep 25, 2024

From #924: handling the metrics for new Temporary error types. This will be done in separate PR.

@leiyiz leiyiz reopened this Sep 25, 2024
@eipi-one eipi-one linked a pull request Oct 9, 2024 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riteshghorse riteshghorse

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
4 participants
@k8s-ci-robot @riteshghorse @leiyiz @k8s-triage-robot