Skip to content

Commit 916eeca

Browse files
Address review comments from copilot
1 parent 6a0d49b commit 916eeca

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

backend/pkg/helm/release.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,12 +606,18 @@ func (h *Handler) installRelease(req InstallRequest) {
606606
return
607607
}
608608

609-
_, err = cs.AuthenticationV1().SelfSubjectReviews().Create(context.Background(), &authv1.SelfSubjectReview{}, metav1.CreateOptions{})
609+
review, err = cs.AuthenticationV1().SelfSubjectReviews().Create(context.Background(), &authv1.SelfSubjectReview{}, metav1.CreateOptions{})
610610
if err != nil {
611611
logger.Log(logger.LevelError, map[string]string{"chart": req.Chart, "releaseName": req.Name}, err, "getting chart")
612612
return
613613
}
614614

615+
if review.Status.Allowed != true {
616+
logger.Log(logger.LevelError, map[string]string{"chart": req.Chart, "releaseName": req.Name},
617+
errors.New("insufficient privileges"), "getting chart: user is not authorized to perform this operation")
618+
return
619+
}
620+
615621
chart, err := h.getChart("install", req.Chart, req.Name,
616622
installClient.ChartPathOptions, req.DependencyUpdate, h.EnvSettings)
617623
if err != nil {

backend/pkg/serviceproxy/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515
func RequestHandler(kubeConfigStore kubeconfig.ContextStore, w http.ResponseWriter, r *http.Request) { //nolint:funlen
1616
name := mux.Vars(r)["name"]
1717
namespace := mux.Vars(r)["namespace"]
18-
requestURI := mux.Vars(r)["request"]
18+
requestURI := r.URL.Query().Get("request")
1919

2020
// Disable caching
2121
w.Header().Set("Cache-Control", "no-cache, private, max-age=0")

0 commit comments

Comments
 (0)