revert unit test

Signed-off-by: Omer Aplatony <[email protected]>

Author: omerap12

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go

@@ -37,6 +37,8 @@ func TestValidateVPA(t *testing.T) {
 	badScalingMode := vpa_types.ContainerScalingMode("bad")
 	badCPUResource := resource.MustParse("187500u")
 	validScalingMode := vpa_types.ContainerScalingModeAuto
+	scalingModeOff := vpa_types.ContainerScalingModeOff
+	controlledValuesRequestsAndLimits := vpa_types.ContainerControlledValuesRequestsAndLimits
 	tests := []struct {
 		name        string
 		vpa         vpa_types.VerticalPodAutoscaler
@@ -164,6 +166,23 @@ func TestValidateVPA(t *testing.T) {
 			},
 			expectError: fmt.Errorf("MaxAllowed: Memory [%v] must be a whole number of bytes", resource.MustParse("500m")),
 		},
+		{
+			name: "scaling off with controlled values requests and limits",
+			vpa: vpa_types.VerticalPodAutoscaler{
+				Spec: vpa_types.VerticalPodAutoscalerSpec{
+					ResourcePolicy: &vpa_types.PodResourcePolicy{
+						ContainerPolicies: []vpa_types.ContainerResourcePolicy{
+							{
+								ContainerName:    "loot box",
+								Mode:             &scalingModeOff,
+								ControlledValues: &controlledValuesRequestsAndLimits,
+							},
+						},
+					},
+				},
+			},
+			expectError: fmt.Errorf("ControlledValues shouldn't be specified if container scaling mode is off."),
+		},
 		{
 			name: "all valid",
 			vpa: vpa_types.VerticalPodAutoscaler{