Skip to content

Commit c3eadc0

Browse files
committed
Fix PRR questionnaire following review
1 parent 241a954 commit c3eadc0

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
kep-number: 4951
22
alpha:
3-
approver: "@deads2k"
3+
approver: "@soltysh"

keps/sig-autoscaling/4951-configurable-hpa-tolerance/README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,8 @@ well as the [existing list] of feature gates.
491491

492492
- [x] Feature gate (also fill in values in `kep.yaml`)
493493
- Feature gate name: HPAConfigurableTolerance
494-
- Components depending on the feature gate: `kube-controller-manager`
494+
- Components depending on the feature gate: `kube-controller-manager` and
495+
`kube-apiserver`.
495496

496497
###### Does enabling the feature change any default behavior?
497498

@@ -517,7 +518,8 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
517518

518519
The feature can be disabled by restarting the `kube-controller-manager` with the feature gate set to `false`.
519520

520-
Any `tolerance` values set on existing HPAs will be ignored by the `kube-controller-manager` when the feature gate is off.
521+
Any `tolerance` values set on existing HPAs will be ignored by the
522+
`kube-controller-manager` and `kube-apiserver` when the feature gate is off.
521523

522524
###### What happens if we reenable the feature if it was previously rolled back?
523525

keps/sig-autoscaling/4951-configurable-hpa-tolerance/kep.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ feature-gates:
4040
disable-supported: true
4141

4242
# The following PRR answers are required at beta release
43-
#metrics:
44-
# - my_feature_metric
43+
metrics:
44+
- horizontal_pod_autoscaler_controller_metric_computation_duration_seconds

0 commit comments

Comments
 (0)