Skip to content

Multiple ingress update cause reloaded N times of nginx instead of just one time for all #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Taymindis opened this issue Mar 15, 2022 · 13 comments
Assignees
Labels
kind/support Categorizes issue or PR as a support question. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Taymindis
Copy link

There are 5 ingress which always been upgraded via using Helm.

Just wondering even If I upgrade 5 ingress's annotations, can it be just reloaded 1 time only?

@Taymindis Taymindis added the kind/bug Categorizes issue or PR as related to a bug. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 15, 2022
@k8s-ci-robot
Copy link
Contributor

@Taymindis: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@longwuyuan
Copy link
Contributor

/remove-kind bug
/kind support

Please provide information that was requested in the new issue template.

5 ingress upgraded means 5 instances of ingress-nginx controller or 5 ingress objects. Looks more like ingress objects but just want to confirm.

If it is ingress objects, did you apply 5 yaml files at once or one by one.

What is the problem you want to solve ?

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 15, 2022
@Taymindis
Copy link
Author

Taymindis commented Mar 15, 2022

Hi @longwuyuan ,

We have our own helm which iterates to create/upgrade ingress objects.

when we modify something on values that apply to relevant ingress object, the N ingress object affected for change will trigger N time of relaod.

I understand that if one ingress object changed, it will RELOAD, but what if I have 30 ingress objects which actually need to reload 30 times from ingress controller?

Solution:

Can it be done by just 1 reload in specific amount of time detection of change?

@longwuyuan
Copy link
Contributor

Someone attempted a hack for a custom behaviour related to disabling admission webhook temporarily, if I am not wrong. They were guided by an expert. While the admission webhook was disabled, the user changed objects and after completing all changes, they re-enabled admission.

I mentioned above incident because there may be ways to achieve it, but there is no feature as per your description. Let us see if other people have comments.

@pdefreitas
Copy link

I'm observing the same issue in our multiple ingress controller setup. To make things a bit more complicated the memory usage increases (and it is not flushed) on every backend reload (just like described in #8166).

@Taymindis
Copy link
Author

@longwuyuan @pdefreitas
The nginx-ingress-controller seemed consuming memory without releasing it, there are just 2 ingress objects only so far.

image

@longwuyuan
Copy link
Contributor

A complete event history and a complete k8s state is needed to make any comments about memory consumption. Please open a new issue to report a new problem. You originally asked for one single reload of nginx in response to multiple config changes. That is a different issue compare from this high-memory consumption issue.

@Taymindis
Copy link
Author

A complete event history and a complete k8s state is needed to make any comments about memory consumption. Please open a new issue to report a new problem. You originally asked for one single reload of nginx in response to multiple config changes. That is a different issue compare from this high-memory consumption issue.

Thanks for reminding, I have reported new issue

@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2022

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

6 participants