[BUG] Multi-container Pod settings gets applied to the first container #2054
Description
Expected Behavior
If I have more than one service, and I use the label group-mode, things should be correctly mapped to the proper container.
Actual Behavior
It seems some, at least one mapping (SecurityContext) is mapped to the first container, and not the one the compose file defined that property
Steps To Reproduce
- Use the provided compose file
- Here dind container should be privileged, cup container is not
- Execute the conversion with
kompose convert --file docker-compose.yaml --service-group-mode label
- Here is the resulting deployment YAML
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
kompose.cmd: kompose convert --file docker-compose.yaml --service-group-mode label
kompose.service.group: cup
kompose.version: 1.36.0 (ae2a39403)
labels:
io.kompose.service: cup
name: cup
spec:
replicas: 1
selector:
matchLabels:
io.kompose.service: cup
template:
metadata:
annotations:
kompose.cmd: kompose convert --file docker-compose.yaml --service-group-mode label
kompose.service.group: cup
kompose.version: 1.36.0 (ae2a39403)
labels:
io.kompose.service: cup
spec:
containers:
- image: ghcr.io/sergi0g/cup:v3.4.0
name: cup
ports:
- containerPort: 8000
protocol: TCP
securityContext:
privileged: true
- image: docker:28.1.1-dind
name: dind
ports:
- containerPort: 2375
protocol: TCP
restartPolicy: Always
- So here, cup container became privileged and dind did not
- Change the name of dind to come alphabetically before cup (adind for example) and rerun
- It will be correct this time
Kompose Version
1.36.0 (ae2a39403)
Docker-Compose file
services:
dind:
container_name: dind
image: docker:28.1.1-dind
labels:
kompose.service.group: cup
ports:
- 2375:2375
privileged: True
cup:
container_name: cup
depends_on:
- dind
image: ghcr.io/sergi0g/cup:v3.4.0
labels:
kompose.service.group: cup
ports:
- 8000:8000Anything else?
Workaround is to properly order the containers.... but if you happen to have more than 2 containers in the compose stack, this becomes impossible.