Disable node-termination-handler

Author: hakman

cmd/kops/integration_test.go

@@ -945,7 +945,7 @@ func TestKarpenter(t *testing.T) {
 		withOIDCDiscovery().
 		withDefaults24().
 		withAddons("karpenter.sh-k8s-1.19").
-		withServiceAccountRole("aws-node-termination-handler.kube-system", true).
+		withoutNTH().
 		withServiceAccountRole("karpenter.kube-system", true)
 	test.expectTerraformFilenames = append(test.expectTerraformFilenames,
 		"aws_s3_object_nodeupscript-karpenter-nodes-single-machinetype_content",

pkg/model/components/nodeterminationhandler.go

@@ -39,12 +39,21 @@ func (b *NodeTerminationHandlerOptionsBuilder) BuildOptions(o *kops.Cluster) err
 		clusterSpec.CloudProvider.AWS.NodeTerminationHandler = &kops.NodeTerminationHandlerSpec{}
 	}
 	nth := clusterSpec.CloudProvider.AWS.NodeTerminationHandler
+	if nth.Enabled == nil {
+		if clusterSpec.Karpenter != nil && clusterSpec.Karpenter.Enabled {
+			// Karpenter manages its own NTH, so we disable the NTH addon.
+			// https://karpenter.sh/docs/troubleshooting/#aws-node-termination-handler-nth-interactions
+			nth.Enabled = fi.PtrTo(false)
+		} else {
+			nth.Enabled = fi.PtrTo(true)
+		}
+	}
+	if !fi.ValueOf(nth.Enabled) {
+		return nil
+	}
 	if nth.DeleteSQSMsgIfNodeNotFound == nil {
 		nth.DeleteSQSMsgIfNodeNotFound = fi.PtrTo(false)
 	}
-	if nth.Enabled == nil {
-		nth.Enabled = fi.PtrTo(true)
-	}
 	if nth.EnableSpotInterruptionDraining == nil {
 		nth.EnableSpotInterruptionDraining = fi.PtrTo(true)
 	}