Remove unused const, variables and function reported by Golangci-lint (#17582)

* Remove unused const, variables and function reported by Golangci-lint

Signed-off-by: Arnaud Meukam <[email protected]>

* make gomod executed
Signed-off-by: Arnaud Meukam <[email protected]>

---------

Signed-off-by: Arnaud Meukam <[email protected]>

Author: ameukam

channels/pkg/cmd/apply_channel.go

@@ -28,7 +28,6 @@ import (
 	"github.com/spf13/cobra"
 	"go.uber.org/multierr"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/cli-runtime/pkg/genericclioptions"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/restmapper"
@@ -40,8 +39,6 @@ import (
 
 type ApplyChannelOptions struct {
 	Yes bool
-
-	configFlags genericclioptions.ConfigFlags
 }
 
 func NewCmdApplyChannel(f *ChannelsFactory, out io.Writer) *cobra.Command {

cloudmock/openstack/mockcompute/api.go

@@ -20,8 +20,6 @@ import (
 	"net/http/httptest"
 	"sync"
 
-	"github.com/gophercloud/gophercloud/v2/openstack/compute/v2/instanceactions"
-
 	"github.com/gophercloud/gophercloud/v2"
 
 	"github.com/gophercloud/gophercloud/v2/openstack/compute/v2/flavors"
@@ -37,13 +35,12 @@ type MockClient struct {
 	openstack.MockOpenstackServer
 	mutex sync.Mutex
 
-	serverGroups    map[string]servergroups.ServerGroup
-	servers         map[string]servers.Server
-	keyPairs        map[string]keypairs.KeyPair
-	images          map[string]images.Image
-	flavors         map[string]flavors.Flavor
-	instanceActions map[string]instanceactions.InstanceAction
-	networkClient   *gophercloud.ServiceClient
+	serverGroups  map[string]servergroups.ServerGroup
+	servers       map[string]servers.Server
+	keyPairs      map[string]keypairs.KeyPair
+	images        map[string]images.Image
+	flavors       map[string]flavors.Flavor
+	networkClient *gophercloud.ServiceClient
 }
 
 // CreateClient will create a new mock networking client

pkg/assets/mirrors.go

@@ -22,12 +22,6 @@ import (
 	"k8s.io/kops"
 )
 
-const (
-	// defaultKopsMirrorBase will be detected and automatically set to pull from the defaultKopsMirrors
-	kopsDefaultBase      = "https://artifacts.k8s.io/binaries/kops/%s/"
-	githubKopsMirrorBase = "https://github.com/kubernetes/kops/releases/download/v%s/"
-)
-
 type mirrorConfig struct {
 	Base    string
 	Mirrors []string

protokube/pkg/protokube/aws_volume.go

@@ -20,7 +20,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"sync"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
 	awsconfig "github.com/aws/aws-sdk-go-v2/config"
@@ -35,8 +34,6 @@ import (
 
 // AWSCloudProvider defines the AWS cloud provider implementation
 type AWSCloudProvider struct {
-	mutex sync.Mutex
-
 	clusterTag string
 	deviceMap  map[string]string
 	ec2        ec2.DescribeInstancesAPIClient

protokube/pkg/protokube/do_volume.go

@@ -29,7 +29,6 @@ import (
 	"github.com/digitalocean/godo"
 	"golang.org/x/oauth2"
 
-	"k8s.io/kops/protokube/pkg/etcd"
 	"k8s.io/kops/protokube/pkg/gossip"
 	gossipdo "k8s.io/kops/protokube/pkg/gossip/do"
 )
@@ -154,31 +153,6 @@ func NewDOCloud() (*godo.Client, error) {
 	return client, nil
 }
 
-// getEtcdClusterSpec returns etcd.EtcdClusterSpec which holds
-// necessary information required for starting an etcd server.
-// DigitalOcean support on kops only supports single master setup for now
-// but in the future when it supports multiple masters this method be
-// updated to handle that case.
-// TODO: use tags once it's supported for volumes
-func (d *DOCloudProvider) getEtcdClusterSpec(vol godo.Volume) (*etcd.EtcdClusterSpec, error) {
-	nodeName := d.dropletName
-
-	var clusterKey string
-	if strings.Contains(vol.Name, "etcd-main") {
-		clusterKey = "main"
-	} else if strings.Contains(vol.Name, "etcd-events") {
-		clusterKey = "events"
-	} else {
-		return nil, fmt.Errorf("could not determine etcd cluster type for volume: %s", vol.Name)
-	}
-
-	return &etcd.EtcdClusterSpec{
-		ClusterKey: clusterKey,
-		NodeName:   nodeName,
-		NodeNames:  []string{nodeName},
-	}, nil
-}
-
 func (d *DOCloudProvider) GossipSeeds() (gossip.SeedProvider, error) {
 	for _, dropletTag := range d.dropletTags {
 		if strings.Contains(dropletTag, strings.ReplaceAll(d.ClusterID, ".", "-")) {

upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go

@@ -869,24 +869,6 @@ func (e *AutoscalingGroup) getLBsToDetach(currentLBs []*ClassicLoadBalancer) []s
 	return lbsToDetach
 }
 
-// getTGsToDetach loops through the currently set LBs and builds a list of
-// target groups to be detached from the Autoscaling Group
-func (e *AutoscalingGroup) getTGsToDetach(currentTGs []*TargetGroup) []*string {
-	tgsToDetach := []*string{}
-	desiredTGs := map[string]bool{}
-
-	for _, v := range e.TargetGroups {
-		desiredTGs[*v.ARN] = true
-	}
-
-	for _, v := range currentTGs {
-		if _, ok := desiredTGs[*v.ARN]; !ok {
-			tgsToDetach = append(tgsToDetach, v.ARN)
-		}
-	}
-	return tgsToDetach
-}
-
 // sliceChunks returns a chunked slice
 func sliceChunks(slice []string, chunkSize int) [][]string {
 	var chunks [][]string

upup/pkg/fi/cloudup/awstasks/network_load_balancer.go

@@ -765,12 +765,6 @@ type deleteNLB struct {
 	obj *awsup.LoadBalancerInfo
 }
 
-func buildDeleteNLB(obj *awsup.LoadBalancerInfo) *deleteNLB {
-	d := &deleteNLB{}
-	d.obj = obj
-	return d
-}
-
 var _ fi.CloudupDeletion = &deleteNLB{}
 
 func (d *deleteNLB) Delete(t fi.CloudupTarget) error {

upup/pkg/fi/cloudup/awsup/aws_authenticator_test.go

@@ -371,12 +371,3 @@ func (s *mockHTTPClient) Do(req *http.Request) (*http.Response, error) {
 	s.t.Fatalf("unexpected request %+v", req)
 	return nil, fmt.Errorf("unexpected request")
 }
-
-type mockHTTPTransport struct {
-	t *testing.T
-}
-
-func (s *mockHTTPTransport) RoundTrip(req *http.Request) (*http.Response, error) {
-	s.t.Fatalf("unexpected request %+v", req)
-	return nil, fmt.Errorf("unexpected request")
-}

upup/pkg/fi/nodeup/command.go

@@ -526,26 +526,6 @@ func evaluateBindAddress(bindAddress string) (string, error) {
 	return bindAddress, nil
 }
 
-// kernelHasFilesystem checks if /proc/filesystems contains the specified filesystem
-func kernelHasFilesystem(fs string) (bool, error) {
-	contents, err := os.ReadFile("/proc/filesystems")
-	if err != nil {
-		return false, fmt.Errorf("error reading /proc/filesystems: %v", err)
-	}
-
-	for _, line := range strings.Split(string(contents), "\n") {
-		tokens := strings.Fields(line)
-		for _, token := range tokens {
-			// Technically we should skip "nodev", but it doesn't matter
-			if token == fs {
-				return true, nil
-			}
-		}
-	}
-
-	return false, nil
-}
-
 // modprobe will exec `modprobe <module>`
 func modprobe(module string) error {
 	klog.Infof("Doing modprobe for module %v", module)