Skip to content

Commit 7808a30

Browse files
authored
Merge pull request #3974 from IrvingMg/fix/generation-release-notes-with-reverted-prs
Include revert PR instead of the reverted one in release notes
2 parents 9a9572f + 4652b9e commit 7808a30

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

pkg/notes/notes.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,13 @@ func prsNumForCommitFromMessage(commitMessage string) (prs []int, err error) {
11361136
prs = append(prs, pr)
11371137
}
11381138

1139+
regex = regexp.MustCompile(`\(#(?P<number>\d+)\)\s*\n\nThis reverts commit`)
1140+
1141+
pr = prForRegex(regex, commitMessage)
1142+
if pr != 0 {
1143+
prs = append(prs, pr)
1144+
}
1145+
11391146
// If the PR was squash merged, the regexp is different
11401147
regex = regexp.MustCompile(`\(#(?P<number>\d+)\)`)
11411148

pkg/notes/notes_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,14 @@ func TestGetPRNumberFromCommitMessage(t *testing.T) {
223223
commitMessage: "Add swapoff to centos so kubelet starts (#504)",
224224
expectedPRNumber: 504,
225225
},
226+
{
227+
name: "Get PR number from revert commit",
228+
commitMessage: `Revert "some pr (#1000)" (#1234)
229+
230+
231+
This reverts commit abcdef1234567890abcdef1234567890abcdef12.`,
232+
expectedPRNumber: 1234,
233+
},
226234
}
227235

228236
for _, tc := range testCases {

0 commit comments

Comments
 (0)