deb packages for kubelet on pkgs.k8s.io seem to include a systemd service definition for redhat machines

[timricese]

What happened:

After updating to 1.28.2 and switching from apt.kubernetes.io to the pkgs.k8s.io repository, KUBELET_EXTRA_ARGS specified in /etc/default/kubelet (as documented: https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/kubelet-integration/#the-kubelet-drop-in-file-for-systemd) no longer were being applied at runtime.

Instead, the systemd service dropin file referred to /etc/sysconfig/kubelet, which is the path used on redhat/rpm machines.

The file that should be included in the deb package is presumably:

release/cmd/kubepkg/templates/latest/deb/kubeadm/10-kubeadm.conf

Line 9 in ec317cd

EnvironmentFile=-/etc/default/kubelet

however it appears to actually be:

release/cmd/kubepkg/templates/latest/rpm/kubeadm/10-kubeadm.conf

Line 9 in ec317cd

EnvironmentFile=-/etc/sysconfig/kubelet

What you expected to happen:

the same EnvironmentFile as documented and previously used in packages from apt.kubernetes.io should still be used.

How to reproduce it (as minimally and precisely as possible):

apt install kubelet=1.28.2-1.1
systemctl cat kubelet.service

Anything else we need to know?:

https://kubernetes.slack.com/archives/C09NXKJKA/p1694790202990129

Environment:

• Cloud provider or hardware configuration: bare metal
• OS (e.g: cat /etc/os-release): Ubuntu 22.04
• Kernel (e.g. uname -a): -
• Others: kubelet==1.28.2-1.1

[xmudrii]

This also caused the issue described in #3219 (comment)
I think that we should look into this as soon as possible. We can't alter existing releases, but we can fix this for future releases. This is mostly like caused by reusing same spec files for both RPM and Debian packages.

/priority critical-urgent
/assign

[xmudrii]

I think this can be easily fixed in the spec file with some sed magic ✨ I'll propose a PR for that on Monday.