From 98514a352494a5ea0f470cf32553ac1d285a769b Mon Sep 17 00:00:00 2001 From: Sreeram Venkitesh Date: Wed, 22 Nov 2023 12:38:30 +0530 Subject: [PATCH 1/3] Added instructions for enabling/disabling enhancement sync job to the handbook --- release-team/role-handbooks/enhancements/README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/release-team/role-handbooks/enhancements/README.md b/release-team/role-handbooks/enhancements/README.md index 369feb9a716..f8b590b4389 100644 --- a/release-team/role-handbooks/enhancements/README.md +++ b/release-team/role-handbooks/enhancements/README.md @@ -135,8 +135,9 @@ It is important that this process be followed and documentation remain up-to-dat - Disable all Workflows for the project - Click `...` -> `Workflows` - For each workflow that enabled (has a green circle next to it), click the workflow and slide the toggle to 'Off' - - Update automation to add issues to the correct Enhancement Tracking Board - - Open a PR into kubernetes/test-infra which to update the [`GITHUB_PROJECT_BETA_NUMBER`](https://github.com/kubernetes/test-infra/blob/3de59f96b327c87c6d23a7308abc785268931707/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L20-L21) variable used by automation to identity the enhancements tracking board for the current release. + - Update automation to add issues to the correct Enhancement Tracking Board. Open a PR into [kubernetes/test-infra](https://github.com/kubernetes/test-infra) with the following changes: + - Update the [`GITHUB_PROJECT_BETA_NUMBER`](https://github.com/kubernetes/test-infra/blob/3de59f96b327c87c6d23a7308abc785268931707/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L20-L21) variable used by automation to identity the enhancements tracking board for the current release. + - Enable the test-infra job that syncs enhancements to the GitHub project board based on the `lead-opt-in` label. Update the name of the [periodic-sync-enhancements-github-project](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L2) cronjob with the version number of the release and enable the cronjob by commenting the impossible cron and uncommenting the `interval`. You can see how this was done for the v1.29 release cycle in [this commit](https://github.com/kubernetes/test-infra/pull/30528/files#diff-9d86ca0a46a2f74a2cf59fff3d18cbba57b5b3489ecc00c36b03f6b6a0c2ac3a). - Create a shortlink for the Tracking Board - Create a free account on [bitly](https://bitly.com/) to create a shortlink for the new Enhancement Tracking Board following the pattern `k8sxyy-enhancements`, e.g. . - Make a [pull request](https://github.com/kubernetes/sig-release/pull/1411) to add the shortlinked Enhancement Tracking Board to the current release page in [sig-release][sig-release]. @@ -245,6 +246,8 @@ See the sig-architecture Enhancements [KEP Template](https://github.com/kubernet - Make sure that number of in-tree open issues with current milestone matches number of opted-in enhancements by checking the Enhancements Tracking Board and GitHub issues with the current milestone. **Note**: in-tree refers to KEPs with PRs inside the [kubernetes/kubernetes](https://github.com/kubernetes/kubernetes) repository. - If a previously removed Enhancement has had their exception Approved, set their **Enhancement Status** to `tracked for enhancement freeze` in the Enhancement Tracking Board. - On Freeze day, email [Kubernetes-Dev](https://groups.google.com/a/kubernetes.io/g/dev) that freeze has happened and upcoming key dates. Examples [1](https://groups.google.com/g/kubernetes-dev/c/JDM7bNKvhqQ/m/8S7BXtXPBQAJ). +- Disable the [periodic-sync-enhancements-github-project](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L2) cronjob which syncs enhancements where the `lead-opt-in` label has been added to the GitHub project board. + - Disable the job by commenting the `interval` and uncommenting the impossible cron date. You can see how this was done in the v.129 release in [this commit](https://github.com/kubernetes/test-infra/commit/064dd07f0164c2aadc12d611f5a851d6cc40afdd). - Remove any Enhancements that failed to meet the criteria by the Enhancement freeze deadline. - Set their **Enhancement Status** in the board to `Removed from Milestone`. - Remove the milestone. From 61b3faa35958740acdeb2e03b30df8fd12fce7c4 Mon Sep 17 00:00:00 2001 From: Sreeram Venkitesh <40194401+sreeram-venkitesh@users.noreply.github.com> Date: Tue, 26 Mar 2024 19:39:52 +0530 Subject: [PATCH 2/3] Update release-team/role-handbooks/enhancements/README.md Co-authored-by: Nina Polshakova --- release-team/role-handbooks/enhancements/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-team/role-handbooks/enhancements/README.md b/release-team/role-handbooks/enhancements/README.md index f8b590b4389..e24346bb9cf 100644 --- a/release-team/role-handbooks/enhancements/README.md +++ b/release-team/role-handbooks/enhancements/README.md @@ -247,7 +247,7 @@ See the sig-architecture Enhancements [KEP Template](https://github.com/kubernet - If a previously removed Enhancement has had their exception Approved, set their **Enhancement Status** to `tracked for enhancement freeze` in the Enhancement Tracking Board. - On Freeze day, email [Kubernetes-Dev](https://groups.google.com/a/kubernetes.io/g/dev) that freeze has happened and upcoming key dates. Examples [1](https://groups.google.com/g/kubernetes-dev/c/JDM7bNKvhqQ/m/8S7BXtXPBQAJ). - Disable the [periodic-sync-enhancements-github-project](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-release-release-team-jobs/release-team-periodics.yaml#L2) cronjob which syncs enhancements where the `lead-opt-in` label has been added to the GitHub project board. - - Disable the job by commenting the `interval` and uncommenting the impossible cron date. You can see how this was done in the v.129 release in [this commit](https://github.com/kubernetes/test-infra/commit/064dd07f0164c2aadc12d611f5a851d6cc40afdd). + - Disable the job by commenting the `interval` and uncommenting the impossible cron date. You can see how this was done in the v1.29 release in [this commit](https://github.com/kubernetes/test-infra/commit/064dd07f0164c2aadc12d611f5a851d6cc40afdd). - Remove any Enhancements that failed to meet the criteria by the Enhancement freeze deadline. - Set their **Enhancement Status** in the board to `Removed from Milestone`. - Remove the milestone. From bf6dedb993f081022c2de4a9914bbd75a7c367c4 Mon Sep 17 00:00:00 2001 From: Sreeram Venkitesh Date: Tue, 26 Mar 2024 19:51:13 +0530 Subject: [PATCH 3/3] Added instructions to add production readiness reviewers and k8s ci bot to the enhancements board --- release-team/role-handbooks/enhancements/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/release-team/role-handbooks/enhancements/README.md b/release-team/role-handbooks/enhancements/README.md index e24346bb9cf..40f3924d53c 100644 --- a/release-team/role-handbooks/enhancements/README.md +++ b/release-team/role-handbooks/enhancements/README.md @@ -124,6 +124,8 @@ It is important that this process be followed and documentation remain up-to-dat - @release-team-comms - @release-team-docs - @release-team-enhancements + - @prod-readiness-reviewers + - Add the @k8s-infra-ci-robot account to the board with **Write** access. - Create all the Fields (columns) for the board > Note: This is currently a manual process and filed to help automate the process. - Until this can be automated; manually create fields with the same `Field Name`, `Field type`, and `Option` values from the previous release's project board.