-
Notifications
You must be signed in to change notification settings - Fork 59
Issue/330 #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Issue/330 #467
Conversation
…Wrapper components
✅ Deploy Preview for kubestellar-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…efinition in MobileTOC
|
Hello @naman9271, I have tried to inject the TOC and MobileMenuBar in the Nextra Mdx wrapper and I have also tried to replicate that but I was running into alot of errors. The example you gave me (Asyncapi), they use custom mdx wrapper implementation. Right now as it is, it's not good enough and that implementation will take me a little bit more time as I am already trying to implement it. Please let me know if you want that implementation or if you have some other suggestion on this. |
|
@rudy128 screenshots looking good you are on right track let me know when you are finished and also share screen recording at the end |
|
@rudy128 could you please make the further changes after taking the pull as we have consolidated the docs into this repo compeltely from ks/ks |
📌 Fixes
Fixes #330 - Add mobile navigation menu and table of contents for responsive documentation experience
Fixes 3578
📝 Summary of Changes
This PR implements a complete mobile navigation solution for the KubeStellar documentation site, addressing the lack of navigation on mobile devices (< 768px) and improving the overall responsive experience.
Key Features Added:
/docs/direct/*URLsChanges Made
🎯 Mobile Navigation Menu
Created
DocsMobileMenu.tsx- Custom mobile sidebar menu component--nextra-navbar-height,--nextra-banner-height)Created
MobileMenuWrapper.tsx- Client-side wrapper componentUpdated
[...slug]/page.tsxUpdated
page.mdx(root docs page)📱 Mobile Table of Contents
Created
MobileTOC.tsx- Collapsible TOC component for mobile/tabletxlbreakpoint (< 1280px)Integrated into page layout
🔍 Search System Refactoring
Created
useSearch.tsxhook with Context ProviderRefactored
DocsNavbar.tsxto use shared search hookUpdated
layout.tsxSearchProviderfor global state sharing🎨 Direct Route Support Enhancement
DirectRouteHighlighter.tsxfunctionality/docs/direct/*URLs🧹 Code Quality
Technical Implementation Details
Z-Index Hierarchy
Responsive Breakpoints
Component Architecture
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
Mobile Navigation Menu
Mobile Table of Contents
Search Integration
👀 Reviewer Notes
Testing Recommendations:
/docs/direct/*) highlight correctlyKey Files to Review:
src/components/docs/DocsMobileMenu.tsx- Main mobile menu logicsrc/components/docs/MobileTOC.tsx- Mobile TOC componentsrc/hooks/useSearch.tsx- Shared search hook with Contextsrc/app/docs/layout.tsx- SearchProvider integrationKnown Considerations:
z-60(above navbarz-20) to create modal overlay effect--nextra-navbar-height,--nextra-banner-heightbuildPageMapForBranch()required for navigation renderingImpact:
This PR significantly improves the mobile UX of the KubeStellar documentation site by: