remove StreamRevision completely.

Author: YoEight

src/KurrentDB.Client/Core/StreamPosition.cs

@@ -30,9 +30,9 @@ public static StreamPosition FromInt64(long value) =>
 		/// </summary>
 		/// <param name="revision"></param>
 		/// <returns></returns>
-		public static StreamPosition FromStreamRevision(StreamRevision revision) => revision.ToUInt64() switch {
+		public static StreamPosition FromStreamRevision(ulong revision) => revision switch {
 			ulong.MaxValue => throw new ArgumentOutOfRangeException(nameof(revision)),
-			_ => new StreamPosition(revision.ToUInt64())
+			_ => new StreamPosition(revision)
 		};
 
 		/// <summary>

src/KurrentDB.Client/Core/StreamRevision.cs

@@ -191,7 +191,7 @@ IWriteResult HandleWrongExpectedRevision(
 			_log.LogDebug(
 				"Append to stream failed with Wrong Expected Version - {streamName}/{expectedRevision}/{currentRevision}",
 				header.Options.StreamIdentifier,
-				new StreamRevision(header.Options.Revision),
+				StreamState.StreamRevision(header.Options.Revision),
 				actualStreamRevision
 			);
 

src/KurrentDB.Client/Streams/KurrentDBClient.Append.cs

@@ -3,28 +3,6 @@
 
 namespace KurrentDB.Client {
 	public partial class KurrentDBClient {
-		/// <summary>
-		/// Deletes a stream asynchronously.
-		/// </summary>
-		/// <param name="streamName">The name of the stream to delete.</param>
-		/// <param name="expectedRevision">The expected <see cref="StreamRevision"/> of the stream being deleted.</param>
-		/// <param name="deadline">The maximum time to wait before terminating the call.</param>
-		/// <param name="userCredentials">The optional <see cref="UserCredentials"/> to perform operation with.</param>
-		/// <param name="cancellationToken">The optional <see cref="System.Threading.CancellationToken"/>.</param>
-		/// <returns></returns>
-		public Task<DeleteResult> DeleteAsync(
-			string streamName,
-			StreamRevision expectedRevision,
-			TimeSpan? deadline = null,
-			UserCredentials? userCredentials = null,
-			CancellationToken cancellationToken = default) =>
-			DeleteInternal(new DeleteReq {
-				Options = new DeleteReq.Types.Options {
-					StreamIdentifier = streamName,
-					Revision = expectedRevision
-				}
-			}, deadline, userCredentials, cancellationToken);
-
 		/// <summary>
 		/// Deletes a stream asynchronously.
 		/// </summary>

src/KurrentDB.Client/Streams/KurrentDBClient.Delete.cs

@@ -60,32 +60,6 @@ public Task<IWriteResult> SetStreamMetadataAsync(string streamName, StreamState
 			}.WithAnyStreamRevision(expectedState), options, deadline, userCredentials, cancellationToken);
 		}
 
-		/// <summary>
-		/// Asynchronously sets the metadata for a stream.
-		/// </summary>
-		/// <param name="streamName">The name of the stream to set metadata for.</param>
-		/// <param name="expectedRevision">The <see cref="StreamRevision"/> of the stream to append to.</param>
-		/// <param name="metadata">A <see cref="StreamMetadata"/> representing the new metadata.</param>
-		/// <param name="configureOperationOptions">An <see cref="Action{KurrentDBClientOperationOptions}"/> to configure the operation's options.</param>
-		/// <param name="deadline"></param>
-		/// <param name="userCredentials">The optional <see cref="UserCredentials"/> to perform operation with.</param>
-		/// <param name="cancellationToken">The optional <see cref="System.Threading.CancellationToken"/>.</param>
-		/// <returns></returns>
-		public Task<IWriteResult> SetStreamMetadataAsync(string streamName, StreamRevision expectedRevision,
-			StreamMetadata metadata, Action<KurrentDBClientOperationOptions>? configureOperationOptions = null,
-			TimeSpan? deadline = null, UserCredentials? userCredentials = null,
-			CancellationToken cancellationToken = default) {
-			var options = Settings.OperationOptions.Clone();
-			configureOperationOptions?.Invoke(options);
-
-			return SetStreamMetadataInternal(metadata, new AppendReq {
-				Options = new AppendReq.Types.Options {
-					StreamIdentifier = SystemStreams.MetastreamOf(streamName),
-					Revision = expectedRevision
-				}
-			}, options, deadline, userCredentials, cancellationToken);
-		}
-
 		private async Task<IWriteResult> SetStreamMetadataInternal(StreamMetadata metadata,
 			AppendReq appendReq,
 			KurrentDBClientOperationOptions operationOptions,

src/KurrentDB.Client/Streams/KurrentDBClient.Metadata.cs

@@ -3,27 +3,6 @@
 
 namespace KurrentDB.Client {
 	public partial class KurrentDBClient {
-		/// <summary>
-		/// Tombstones a stream asynchronously. Note: Tombstoned streams can never be recreated.
-		/// </summary>
-		/// <param name="streamName">The name of the stream to tombstone.</param>
-		/// <param name="expectedRevision">The expected <see cref="StreamRevision"/> of the stream being deleted.</param>
-		/// <param name="deadline"></param>
-		/// <param name="userCredentials">The optional <see cref="UserCredentials"/> to perform operation with.</param>
-		/// <param name="cancellationToken">The optional <see cref="System.Threading.CancellationToken"/>.</param>
-		/// <returns></returns>
-		public Task<DeleteResult> TombstoneAsync(
-			string streamName,
-			StreamRevision expectedRevision,
-			TimeSpan? deadline = null,
-			UserCredentials? userCredentials = null,
-			CancellationToken cancellationToken = default) => TombstoneInternal(new TombstoneReq {
-			Options = new TombstoneReq.Types.Options {
-				StreamIdentifier = streamName,
-				Revision = expectedRevision
-			}
-		}, deadline, userCredentials, cancellationToken);
-
 		/// <summary>
 		/// Tombstones a stream asynchronously. Note: Tombstoned streams can never be recreated.
 		/// </summary>

src/KurrentDB.Client/Streams/KurrentDBClient.Tombstone.cs

@@ -66,12 +66,9 @@ public void ArgumentOutOfRange(ulong value) {
 		Assert.Equal(nameof(value), ex.ParamName);
 	}
 
-	[RetryFact]
-	public void FromStreamPositionEndThrows() => Assert.Throws<ArgumentOutOfRangeException>(() => StreamRevision.FromStreamPosition(StreamPosition.End));
-
 	[RetryFact]
 	public void FromStreamPositionReturnsExpectedResult() {
-		var result = StreamPosition.FromStreamRevision(new(0));
+		var result = StreamPosition.FromStreamRevision(0);
 
 		Assert.Equal(new(0), result);
 	}