Skip to content

Commit a9c8f63

Browse files
committed
Some EventStoreDB renaming in otel and readme
1 parent 88f6db5 commit a9c8f63

File tree

6 files changed

+16
-18
lines changed

6 files changed

+16
-18
lines changed

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ repositories {
3131

3232
## Developing
3333

34-
The SDK is built using [`Gradle`][gradle]. Integration tests run against a server using Docker, with the [Kurrent gRPC Client Test Container][container].
34+
The SDK is built using [`Gradle`][gradle]. Integration tests run against a server using Docker.
3535

3636
### Run tests
3737

3838
Tests are written using [TestContainers](https://www.testcontainers.org/) and require [Docker](https://www.docker.com/) to be installed.
3939

40-
Specific docker images can be specified via the enviroment variable `EVENTSTORE_IMAGE`.
40+
Specific docker images can be specified via the environment variable `EVENTSTORE_IMAGE`.
4141

4242
## Open Telemetry
4343

@@ -164,7 +164,7 @@ CountResult result = client
164164
.get();
165165
```
166166

167-
For further details please see [the projection management tests](src/test/java/com/eventstore/dbclient/ProjectionManagementTests.java).
167+
For further details please see [the projection management tests](src/test/java/io/kurrent/dbclient/ProjectionManagementTests.java).
168168

169169
## Support
170170

@@ -193,7 +193,6 @@ review our [Contributing Guide][contributing] and [Code of Conduct][code-of-cond
193193

194194
[kurrent]: https://kurrent.io
195195
[gradle]: https://gradle.org
196-
[container]: https://github.com/Kurrent/Kurrent-Client-gRPC-TestData
197196
[contributing]: https://github.com/Kurrent/Kurrent-Client-Java/tree/master/CONTRIBUTING.md
198197
[code-of-conduct]: https://github.com/Kurrent/Kurrent-Client-Java/tree/master/CODE-OF-CONDUCT.md
199198
[support]: https://kurrent.io/support/

db-client-java/src/main/java/io/kurrent/dbclient/ClientTelemetry.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ static CompletableFuture<WriteResult> traceAppend(
9494
SpanKind.CLIENT,
9595
null,
9696
ClientTelemetryTags.builder()
97-
.withRequiredTag(ClientTelemetryAttributes.EventStore.STREAM, streamId)
97+
.withRequiredTag(ClientTelemetryAttributes.Kurrent.STREAM, streamId)
9898
.withServerTagsFromGrpcChannel(channel)
9999
.withServerTagsFromClientSettings(settings)
100100
.withOptionalDatabaseUserTag(settings.getDefaultCredentials())
@@ -139,10 +139,10 @@ static void traceSubscribe(Runnable tracedOperation, String subscriptionId, Mana
139139
SpanKind.CONSUMER,
140140
remoteParentContext,
141141
ClientTelemetryTags.builder()
142-
.withRequiredTag(ClientTelemetryAttributes.EventStore.STREAM, event.getStreamId())
143-
.withRequiredTag(ClientTelemetryAttributes.EventStore.SUBSCRIPTION_ID, subscriptionId)
144-
.withRequiredTag(ClientTelemetryAttributes.EventStore.EVENT_ID, event.getEventId().toString())
145-
.withRequiredTag(ClientTelemetryAttributes.EventStore.EVENT_TYPE, event.getEventType())
142+
.withRequiredTag(ClientTelemetryAttributes.Kurrent.STREAM, event.getStreamId())
143+
.withRequiredTag(ClientTelemetryAttributes.Kurrent.SUBSCRIPTION_ID, subscriptionId)
144+
.withRequiredTag(ClientTelemetryAttributes.Kurrent.EVENT_ID, event.getEventId().toString())
145+
.withRequiredTag(ClientTelemetryAttributes.Kurrent.EVENT_TYPE, event.getEventType())
146146
.withServerTagsFromGrpcChannel(channel)
147147
.withServerTagsFromClientSettings(settings)
148148
.withOptionalDatabaseUserTag(settings.getDefaultCredentials())

db-client-java/src/main/java/io/kurrent/dbclient/ClientTelemetryAttributes.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package io.kurrent.dbclient;
22

33
import io.opentelemetry.semconv.ExceptionAttributes;
4-
import io.opentelemetry.semconv.OtelAttributes;
54
import io.opentelemetry.semconv.ServerAttributes;
65
import io.opentelemetry.semconv.incubating.DbIncubatingAttributes;
76

@@ -23,7 +22,7 @@ public static class Exceptions {
2322
public static final String STACK_TRACE = ExceptionAttributes.EXCEPTION_STACKTRACE.getKey();
2423
}
2524

26-
public static class EventStore {
25+
public static class Kurrent {
2726
public static final String STREAM = "db.kurrent.stream";
2827
public static final String SUBSCRIPTION_ID = "db.kurrent.subscription.id";
2928
public static final String EVENT_ID = "db.kurrent.event.id";

db-client-java/src/main/java/io/kurrent/dbclient/ClientTelemetryConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.kurrent.dbclient;
22

33
public class ClientTelemetryConstants {
4-
public static final String INSTRUMENTATION_NAME = "eventstoredb";
4+
public static final String INSTRUMENTATION_NAME = "kurrent";
55

66
public static class Metadata {
77
public static final String TRACE_ID = "$traceId";

db-client-java/src/main/java/io/kurrent/dbclient/UnsupportedFeatureException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.kurrent.dbclient;
22

33
/**
4-
* A request not supported by the targeted EventStoreDB node was sent.
4+
* A request not supported by the targeted KurrentDB node was sent.
55
*/
66
public class UnsupportedFeatureException extends RuntimeException {
77
UnsupportedFeatureException(){

db-client-java/src/test/java/io/kurrent/dbclient/telemetry/TelemetryAware.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public interface TelemetryAware extends ConnectionAware {
2121
default void assertAppendSpanHasExpectedAttributes(ReadableSpan span, String streamName) {
2222
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.SYSTEM, ClientTelemetryConstants.INSTRUMENTATION_NAME);
2323
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.OPERATION, ClientTelemetryConstants.Operations.APPEND);
24-
assertSpanAttributeEquals(span, ClientTelemetryAttributes.EventStore.STREAM, streamName);
24+
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Kurrent.STREAM, streamName);
2525
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.USER, "admin");
2626
Assertions.assertEquals(StatusCode.OK, span.toSpanData().getStatus().getStatusCode());
2727
Assertions.assertEquals(SpanKind.CLIENT, span.getKind());
@@ -42,10 +42,10 @@ default void assertSubscriptionActivityHasExpectedAttributes(ReadableSpan span,
4242
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.SYSTEM, ClientTelemetryConstants.INSTRUMENTATION_NAME);
4343
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.OPERATION, ClientTelemetryConstants.Operations.SUBSCRIBE);
4444
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Database.USER, "admin");
45-
assertSpanAttributeEquals(span, ClientTelemetryAttributes.EventStore.STREAM, streamName);
46-
assertSpanAttributeEquals(span, ClientTelemetryAttributes.EventStore.SUBSCRIPTION_ID, subscriptionId);
47-
assertSpanAttributeEquals(span, ClientTelemetryAttributes.EventStore.EVENT_ID, eventId);
48-
assertSpanAttributeEquals(span, ClientTelemetryAttributes.EventStore.EVENT_TYPE, eventType);
45+
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Kurrent.STREAM, streamName);
46+
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Kurrent.SUBSCRIPTION_ID, subscriptionId);
47+
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Kurrent.EVENT_ID, eventId);
48+
assertSpanAttributeEquals(span, ClientTelemetryAttributes.Kurrent.EVENT_TYPE, eventType);
4949
Assertions.assertEquals(StatusCode.OK, span.toSpanData().getStatus().getStatusCode());
5050
Assertions.assertEquals(SpanKind.CONSUMER, span.getKind());
5151
}

0 commit comments

Comments
 (0)