Repository navigation
Refactoring scripting.ts - #998
Closed
concertypin wants to merge 1 commit into
Closed
concertypin wants to merge 1 commit into
concertypin wants to merge 1 commit into
Conversation
2 of 3 tasks
3 tasks done
3 of 10 tasks
kwaroran
added a commit
that referenced
this pull request
Jan 30, 2026
…1211) ## PR Checklist - Required Checks - [x] Have you added type definitions? - [x] Have you tested your changes? - [x] Have you checked that it won't break any existing features? - [ ] If your PR uses models[^1], if true, check the following: - [ ] Have you checked if it works normally in all models? - [ ] Have you checked if it works normally in all web, local, and node hosted versions? If it doesn't, have you blocked it in those versions? - [ ] If your PR is highly ai generated[^2], check the following: - [ ] Have you understanded what the code does? - [ ] Have you cleaned up any unnecessary or redundant code? - [ ] Is is not a huge change? - We currently do not accept highly ai generated PRs that are large changes. [^1]: Modifies the behavior of prompting, requesting or handling responses from ai models. [^2]: Almost over 80% of the code is ai generated. ## Summary The defaultValue property was added to alertInput to allow pre-entering of a word. ## Related Issues During testing, pressing the Esc key occasionally resulted in 0 being entered. This is a bug caused by interaction with the Esc button, and will need to be fixed later, but is not covered in this PR. ## Changes A defaultValue property was added to alertInput, and some elements that use alertInput were modified to use defaultValue. Key and password fields were not touched. ## Impact For example, when renaming bookmarks, folders, etc., you can edit the desired field instead of renaming them from beginning. This feature can also be used in other development projects. <img width="248" height="197" alt="image" src="https://github.com/user-attachments/assets/3cff31b6-7b2b-4b2e-92c8-0622377dcca2" /> ## Additional Notes This feature needs to be modified to work with v2trigger and lua, but since another PR #998 is currently in progress, I'll rewrite this later.
cubicj
reviewed
Jul 12, 2026
cubicj
left a comment
cubicj
left a comment
Collaborator
There was a problem hiding this comment.
The split itself checks out, but main kept adding APIs to scriptings.ts after this branch deleted it, so the merge is now a modify/delete conflict and redoing the split on top of the current main looks cheaper than untangling this branch. Would you be interested in continuing this on the current main?
yor42
pushed a commit
to yor42/RisuTanium
that referenced
this pull request
Sep 21, 2026
…waroran#1211) ## PR Checklist - Required Checks - [x] Have you added type definitions? - [x] Have you tested your changes? - [x] Have you checked that it won't break any existing features? - [ ] If your PR uses models[^1], if true, check the following: - [ ] Have you checked if it works normally in all models? - [ ] Have you checked if it works normally in all web, local, and node hosted versions? If it doesn't, have you blocked it in those versions? - [ ] If your PR is highly ai generated[^2], check the following: - [ ] Have you understanded what the code does? - [ ] Have you cleaned up any unnecessary or redundant code? - [ ] Is is not a huge change? - We currently do not accept highly ai generated PRs that are large changes. [^1]: Modifies the behavior of prompting, requesting or handling responses from ai models. [^2]: Almost over 80% of the code is ai generated. ## Summary The defaultValue property was added to alertInput to allow pre-entering of a word. ## Related Issues During testing, pressing the Esc key occasionally resulted in 0 being entered. This is a bug caused by interaction with the Esc button, and will need to be fixed later, but is not covered in this PR. ## Changes A defaultValue property was added to alertInput, and some elements that use alertInput were modified to use defaultValue. Key and password fields were not touched. ## Impact For example, when renaming bookmarks, folders, etc., you can edit the desired field instead of renaming them from beginning. This feature can also be used in other development projects. <img width="248" height="197" alt="image" src="https://github.com/user-attachments/assets/3cff31b6-7b2b-4b2e-92c8-0622377dcca2" /> ## Additional Notes This feature needs to be modified to work with v2trigger and lua, but since another PR kwaroran#998 is currently in progress, I'll rewrite this later.
Contributor
|
Hi @concertypin, If possible, could you let us know whether you plan to continue working on this PR? We really appreciate your contribution, but since this PR has remained unmerged for quite some time, it has started to hold back the introduction of some related features. A quick update from you would help the community coordinate development. Thank you! |
Contributor
Author
|
Too stale to continue working. I'll make a new PR from scratch. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Since scripting.ts is too long to read, separate it into some pieces of file.