Skip to content

Commit 8fb8b6c

Browse files
committed
Merge branch 'manylinux-bump' into m134-public
2 parents 4aa26de + 80e4d45 commit 8fb8b6c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
uses: docker/setup-qemu-action@v3
3131
- name: Build skia 3rd-Party
3232
# Taken from https://github.com/pypa/cibuildwheel/blob/v2.19.2/cibuildwheel/resources/pinned_docker_images.cfg
33-
uses: docker://quay.io/pypa/manylinux2014_aarch64:2024.07.02-0
33+
uses: docker://quay.io/pypa/manylinux_2_28_aarch64:2024.07.02-0
3434
if: ${{ steps.cache-skia.outputs.cache-hit != 'true' }}
3535
with:
3636
args: bash -c "git config --global --add safe.directory '*' &&
@@ -61,7 +61,7 @@ jobs:
6161
- name: Set up QEMU
6262
uses: docker/setup-qemu-action@v3
6363
- name: Build Skia Proper
64-
uses: docker://quay.io/pypa/manylinux2014_aarch64:2024.07.02-0
64+
uses: docker://quay.io/pypa/manylinux_2_28_aarch64:2024.07.02-0
6565
with:
6666
args: bash -c "git config --global --add safe.directory '*' &&
6767
bash scripts/build_Linux.sh
@@ -116,6 +116,8 @@ jobs:
116116
- name: Build wheels
117117
uses: pypa/[email protected]
118118
env:
119+
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
120+
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28
119121
CIBW_BUILD: "${{ matrix.cp }}-*"
120122
CIBW_SKIP: "*musllinux*"
121123
CIBW_ARCHS: ${{ matrix.arch }}
@@ -179,6 +181,8 @@ jobs:
179181
- name: Build wheels
180182
uses: pypa/[email protected]
181183
env:
184+
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
185+
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28
182186
CIBW_BUILD: "${{ matrix.cp }}-*"
183187
CIBW_SKIP: "*musllinux*"
184188
CIBW_ARCHS: ${{ matrix.arch }}

scripts/build_Linux.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ if [[ $(uname -m) == "aarch64" ]]; then
3333
yum -y install epel-release && \
3434
yum repolist && \
3535
yum install -y ninja-build && \
36-
ln -s ninja-build /usr/bin/ninja &&
3736
mv depot_tools/ninja depot_tools/ninja.bak
3837
fi
3938

@@ -54,7 +53,7 @@ fi
5453
git clone https://gn.googlesource.com/gn && \
5554
cd gn && \
5655
git checkout fe330c0ae1ec29db30b6f830e50771a335e071fb && \
57-
python build/gen.py && \
56+
python3 build/gen.py && \
5857
ninja -C out gn && \
5958
cd ..
6059

0 commit comments

Comments
 (0)