Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite to use this.data correctly #6

Open
kylebakerio opened this issue Oct 17, 2022 · 0 comments
Open

rewrite to use this.data correctly #6

kylebakerio opened this issue Oct 17, 2022 · 0 comments

Comments

@kylebakerio
Copy link
Owner

when I first started building this component, I wasn't aware that one should never touch this.data directly, and only modify those values through this.el.setAttribute, which caused issues with the component and made some of the code a mess in the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylebakerio