bug: variable helm_keyring issue with helm v3

[wegreentick]

Summary

to upgrade helm v3, i am using main branch

• lablabs/terraform-aws-eks-cert-manager@0b507b9 that points to https://github.com/lablabs/terraform-aws-eks-universal-addon/releases/tag/v1.0.0-rc1

With terraform plan, i observe below error.

│ Error: Provider produced invalid plan
│ 
│ Provider "registry.terraform.io/hashicorp/helm" planned an invalid value for module.shared_alb_controller[0].module.addon.helm_release.this[0].keyring: planned
│ value cty.NullVal(cty.String) does not match config value cty.StringVal("~/.gnupg/pubring.gpg").
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│ 
│ Provider "registry.terraform.io/hashicorp/helm" planned an invalid value for module.external_dns.module.addon.helm_release.this[0].keyring: planned value
│ cty.NullVal(cty.String) does not match config value cty.StringVal("~/.gnupg/pubring.gpg").
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│ 
│ Provider "registry.terraform.io/hashicorp/helm" planned an invalid value for module.cert_manager.module.addon.helm_release.this[0].keyring: planned value
│ cty.NullVal(cty.String) does not match config value cty.StringVal("~/.gnupg/pubring.gpg").

│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵
╷
│ Error: Provider produced invalid plan
│ 
│ Provider "registry.terraform.io/hashicorp/helm" planned an invalid value for module.cluster_autoscaler.module.addon.helm_release.this[0].keyring: planned value
│ cty.NullVal(cty.String) does not match config value cty.StringVal("~/.gnupg/pubring.gpg").
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.


##
╷
│ Warning: Deprecated attribute
│ 
│   on .terraform/modules/cluster_autoscaler/main.tf line 40, in locals:
│   40:     awsRegion = data.aws_region.current.name
│ 
│ The attribute "name" is deprecated. Refer to the provider documentation for details.
╵
╷
│ Warning: Deprecated Resource
│ 
│   with module.cert_manager.module.addon.kubernetes_role.helm_argo_application_wait,
│   on .terraform/modules/cert_manager.addon/modules/addon/argo-helm.tf line 28, in resource "kubernetes_role" "helm_argo_application_wait":
│   28: resource "kubernetes_role" "helm_argo_application_wait" {
│ 
│ Deprecated; use kubernetes_role_v1.
│ 
│ (and 19 more similar warnings elsewhere)
╵

Issue Type

Bug Report

Terraform Version

Terraform v1.13.0
on darwin_arm64
+ provider registry.terraform.io/alekc/kubectl v2.1.3
+ provider registry.terraform.io/cloudposse/utils v2.0.2
+ provider registry.terraform.io/hashicorp/aws v6.28.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.3.7
+ provider registry.terraform.io/hashicorp/helm v3.1.1
+ provider registry.terraform.io/hashicorp/kubernetes v3.0.1
+ provider registry.terraform.io/hashicorp/null v3.2.3
+ provider registry.terraform.io/hashicorp/random v3.6.3
+ provider registry.terraform.io/hashicorp/time v0.13.1
+ provider registry.terraform.io/hashicorp/tls v4.2.1
+ provider registry.terraform.io/lablabs/lara-utils v0.0.1

Your version of Terraform is out of date! The latest version
is 1.14.6. You can update by downloading from https://developer.hashicorp.com/terraform/install

Steps to Reproduce

use branch main as source and terraform init -upgrade and terraform plan, you will observe error.

module "cert_manager" {
  source = "github.com/lablabs/terraform-aws-eks-cert-manager?ref=main"
}

Expected Results

no error with plan or apply with terraform

Actual Results

╷
│ Error: Provider produced invalid plan
│ 
│ Provider "registry.terraform.io/hashicorp/helm" planned an invalid value for module.cert_manager.module.addon.helm_release.this[0].keyring: planned value
│ cty.NullVal(cty.String) does not match config value cty.StringVal("~/.gnupg/pubring.gpg").

│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵

[mliner]

Hi @wegreentick, I've created this fix https://github.com/lablabs/terraform-aws-eks-universal-addon/pull/101/changes that should solve the issue. Once merged I'll push new universal-addon RC version to this repo main branch.

[mliner]

@wegreentick fix pushed to the cert-manager main

[wegreentick]

thank you @mliner for your quick response and fix, i will wait for changes to push to others controller repos like autoscaler, load-balancer, cert-manager, external-dns as well

[wegreentick]

thank you again @mliner, the new changes are working now.

Just to add, there are Deprecation warning which I assume you are already aware of it in module 'cluster_autoscaler' and 'cert_manager'

│ Warning: Deprecated attribute
│ 
│   on .terraform/modules/cluster_autoscaler/main.tf line 40, in locals:
│   40:     awsRegion = data.aws_region.current.name
│ 
│ The attribute "name" is deprecated. Refer to the provider documentation for details.
│ 
│ (and one more similar warning elsewhere)
╵
╷
│ Warning: Deprecated Resource
│ 
│   with module.cert_manager.module.addon.kubernetes_role.helm_argo_application_wait,
│   on .terraform/modules/cert_manager.addon/modules/addon/argo-helm.tf line 28, in resource "kubernetes_role" "helm_argo_application_wait":
│   28: resource "kubernetes_role" "helm_argo_application_wait" {
│ 
│ Deprecated; use kubernetes_role_v1.
│ 
│ (and 19 more similar warnings elsewhere)